chrome/browser/chromeos/policy/policy_cert_verifier.cc - Issue 1994353002: Update CertVerifier::Verify to use RequestParams instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/policy_cert_verifier.cc

Issue 1994353002: Update CertVerifier::Verify to use RequestParams instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@request_params

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/policy_cert_verifier.h ('k') | chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/policy_cert_verifier.cc

diff --git a/chrome/browser/chromeos/policy/policy_cert_verifier.cc b/chrome/browser/chromeos/policy/policy_cert_verifier.cc

index 1d29a99bf823aacba33409bb0e0536ce15fdebcd..4743480000e94d7306bc85cb4b286beb833e588e 100644

--- a/chrome/browser/chromeos/policy/policy_cert_verifier.cc

+++ b/chrome/browser/chromeos/policy/policy_cert_verifier.cc

@@ -69,10 +69,7 @@ void PolicyCertVerifier::SetTrustAnchors(

}

int PolicyCertVerifier::Verify(

- net::X509Certificate* cert,

- const std::string& hostname,

- const std::string& ocsp_response,

- int flags,

+ const RequestParams& params,

net::CRLSet* crl_set,

net::CertVerifyResult* verify_result,

const net::CompletionCallback& completion_callback,

@@ -85,9 +82,8 @@ int PolicyCertVerifier::Verify(

anchor_used_callback_,

completion_callback,

verify_result);

- int error =

- delegate_->Verify(cert, hostname, ocsp_response, flags, crl_set,

- verify_result, wrapped_callback, out_req, net_log);

+ int error = delegate_->Verify(params, crl_set, verify_result,

+ wrapped_callback, out_req, net_log);

MaybeSignalAnchorUse(error, anchor_used_callback_, *verify_result);

return error;

}