Remove Release() from IFXCRT_FileAccess

Remove Release() from IFXCRT_FileAccess.

Remove some unused impls.

Committed: https://pdfium.googlesource.com/pdfium/+/411f1185f44b7862a9b1c16e588407ae197752dd

[Tom Sepez, 2016-05-19 22:10:00]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-19 22:10:00]

Lei, for review.

[Lei Zhang, 2016-05-19 22:50:05]

There's another FXCRT_FileAccess_Create() impl in
core/fxcrt/fxcrt_platforms.cpp, but it's not obvious who is using it.

https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:83: if (!pFA)
IFXCRT_FileAccess::Create() can't fail.

https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:87: return new CFX_CRTFileStream(pFA.release());
CFX_CRTFileStream should take a unique_ptr. The only 2 callers are here and
below according to Code Search.

[Tom Sepez, 2016-05-19 23:05:59]

On 2016/05/19 22:50:05, Lei Zhang wrote:
> There's another FXCRT_FileAccess_Create() impl in
> core/fxcrt/fxcrt_platforms.cpp, but it's not obvious who is using it.
> 
> https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp
> File core/fxcrt/fx_extension.cpp (right):
> 
>
https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp...
> core/fxcrt/fx_extension.cpp:83: if (!pFA)
> IFXCRT_FileAccess::Create() can't fail.
> 
>
https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp...
> core/fxcrt/fx_extension.cpp:87: return new CFX_CRTFileStream(pFA.release());
> CFX_CRTFileStream should take a unique_ptr. The only 2 callers are here and
> below according to Code Search.

Guarded by
#if (_FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_ && \
     _FXM_PLATFORM_ != _FXM_PLATFORM_LINUX_ &&   \
     _FXM_PLATFORM_ != _FXM_PLATFORM_APPLE_ &&   \
     _FXM_PLATFORM_ != _FXM_PLATFORM_ANDROID_)

and yet in fx_system.h, the only values are:

// _FXM_PLATFORM_ values;                                                       
                                                                              
#define _FXM_PLATFORM_WINDOWS_ 1  // _FX_WIN32_DESKTOP_ or _FX_WIN64_DESKTOP_.  
                                                                              
#define _FXM_PLATFORM_LINUX_ 2    // _FX_LINUX_DESKTOP_ always.                 
                                                                              
#define _FXM_PLATFORM_APPLE_ 3    // _FX_MACOSX_ always.                        
                                                                              
#define _FXM_PLATFORM_ANDROID_ 4  // _FX_ANDROID_ always.                       
                                                                              

So I would conclude "nobody".

[Tom Sepez, 2016-05-19 23:13:51]

Description was changed from

==========
Remove Release() from IFXCRT_FileAccess
==========

to

==========
Remove Release() from IFXCRT_FileAccess.

Remove some unused impls.
==========

[Tom Sepez, 2016-05-19 23:18:31]

https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:83: if (!pFA)
On 2016/05/19 22:50:05, Lei Zhang wrote:
> IFXCRT_FileAccess::Create() can't fail.

Done.

https://codereview.chromium.org/1994323002/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:87: return new CFX_CRTFileStream(pFA.release());
On 2016/05/19 22:50:05, Lei Zhang wrote:
> CFX_CRTFileStream should take a unique_ptr. The only 2 callers are here and
> below according to Code Search.

Done.

[Lei Zhang, 2016-05-19 23:59:03]

lgtm

https://codereview.chromium.org/1994323002/diff/40001/core/fxcrt/fx_extension...
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/1994323002/diff/40001/core/fxcrt/fx_extension...
core/fxcrt/fx_extension.cpp:18: : m_pFile(std::move(pFA)), m_dwCount(1) {}
#include <utility>

[Tom Sepez, 2016-05-20 00:13:53]

https://codereview.chromium.org/1994323002/diff/40001/core/fxcrt/fx_extension...
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/1994323002/diff/40001/core/fxcrt/fx_extension...
core/fxcrt/fx_extension.cpp:18: : m_pFile(std::move(pFA)), m_dwCount(1) {}
On 2016/05/19 23:59:02, Lei Zhang wrote:
> #include <utility>

Done.

[Tom Sepez, 2016-05-20 00:13:56]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-20 00:13:57]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1994323002/#ps60001
(title: "include <utility>.")

[commit-bot: I haz the power, 2016-05-20 00:14:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994323002/60001

[commit-bot: I haz the power, 2016-05-20 00:31:05]

Description was changed from

==========
Remove Release() from IFXCRT_FileAccess.

Remove some unused impls.
==========

to

==========
Remove Release() from IFXCRT_FileAccess.

Remove some unused impls.

Committed:
https://pdfium.googlesource.com/pdfium/+/411f1185f44b7862a9b1c16e588407ae1977...
==========

[commit-bot: I haz the power, 2016-05-20 00:31:06]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/411f1185f44b7862a9b1c16e588407ae1977...