Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1994303002: sandbox: fix DeathMessage tests in official builds (Closed)

Created:
4 years, 7 months ago by mdempsky
Modified:
4 years, 7 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, krasin1, ilja, tfiga
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox: fix DeathMessage tests in official builds It seems that official builds now use the "ud2" instruction to handle CHECK failures, which causes the process to exit due to SIGILL instead of SIGABRT. Unclear at the moment exactly why (maybe a toolchain change?), but easy to workaround for now. TBR=jln@chromium.org BUG=612507 Committed: https://crrev.com/c13ff44abef008d4117b54d01ebf4912275c5fc6 Cr-Commit-Position: refs/heads/master@{#394867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sandbox/linux/tests/unit_tests.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mdempsky
jln/rickyz: PTAL krasin/ihf/tfiga: FYI. I tested that this passes using krasin's repro steps from crbug.com/612507 ...
4 years, 7 months ago (2016-05-19 20:08:24 UTC) #2
krasin
LGTM
4 years, 7 months ago (2016-05-19 20:35:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994303002/1
4 years, 7 months ago (2016-05-19 20:43:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 21:17:53 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:19:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c13ff44abef008d4117b54d01ebf4912275c5fc6
Cr-Commit-Position: refs/heads/master@{#394867}

Powered by Google App Engine
This is Rietveld 408576698