Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1994293002: Add missing gyp dependency for timeline_message_handler.js. (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing gyp dependency for timeline_message_handler.js. Resort list. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8994228d8182dff6ab421461b745bf855d14dbd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M runtime/observatory/observatory_sources.gypi View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 7 months ago (2016-05-19 19:28:25 UTC) #2
Cutch
lgtm
4 years, 7 months ago (2016-05-19 19:30:00 UTC) #3
rmacnak
4 years, 7 months ago (2016-05-19 19:35:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8994228d8182dff6ab421461b745bf855d14dbd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698