Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1994223003: views/mus: Add a test to verify that Widget receives events correctly. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Add a test to verify that Widget receives events correctly. BUG=none Committed: https://crrev.com/2b3ae3b8090361f8af5a611712fc1a5ab2de53cb Cr-Commit-Position: refs/heads/master@{#394939}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M components/mus/public/cpp/tests/window_tree_client_impl_private.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_private.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus_unittest.cc View 1 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sadrul
unit-test for https://codereview.chromium.org/1990333002/
4 years, 7 months ago (2016-05-19 20:37:13 UTC) #2
sky
LGTM with a better name. https://codereview.chromium.org/1994223003/diff/1/components/mus/public/cpp/tests/window_tree_client_impl_private.h File components/mus/public/cpp/tests/window_tree_client_impl_private.h (right): https://codereview.chromium.org/1994223003/diff/1/components/mus/public/cpp/tests/window_tree_client_impl_private.h#newcode37 components/mus/public/cpp/tests/window_tree_client_impl_private.h:37: void PretendReceiveEvent(Window* window, const ...
4 years, 7 months ago (2016-05-19 20:58:23 UTC) #3
sadrul
https://codereview.chromium.org/1994223003/diff/1/components/mus/public/cpp/tests/window_tree_client_impl_private.h File components/mus/public/cpp/tests/window_tree_client_impl_private.h (right): https://codereview.chromium.org/1994223003/diff/1/components/mus/public/cpp/tests/window_tree_client_impl_private.h#newcode37 components/mus/public/cpp/tests/window_tree_client_impl_private.h:37: void PretendReceiveEvent(Window* window, const ui::Event& event); On 2016/05/19 20:58:23, ...
4 years, 7 months ago (2016-05-19 21:52:35 UTC) #4
sky
SLGTM
4 years, 7 months ago (2016-05-19 21:58:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994223003/20001
4 years, 7 months ago (2016-05-19 22:46:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/232395)
4 years, 7 months ago (2016-05-19 23:52:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994223003/20001
4 years, 7 months ago (2016-05-20 00:22:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 00:58:46 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 01:00:45 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2b3ae3b8090361f8af5a611712fc1a5ab2de53cb
Cr-Commit-Position: refs/heads/master@{#394939}

Powered by Google App Engine
This is Rietveld 408576698