Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/compiler.cc

Issue 1994223002: [Compiler] Skip Ignition for asm.js code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Skip Ignition but don't go straight to TF Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler.h" 5 #include "src/compiler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "src/ast/ast-numbering.h" 9 #include "src/ast/ast-numbering.h"
10 #include "src/ast/prettyprinter.h" 10 #include "src/ast/prettyprinter.h"
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 CHECK(!info->shared_info()->feedback_vector()->metadata()->SpecDiffersFrom( 427 CHECK(!info->shared_info()->feedback_vector()->metadata()->SpecDiffersFrom(
428 info->literal()->feedback_vector_spec())); 428 info->literal()->feedback_vector_spec()));
429 } 429 }
430 430
431 bool UseIgnition(CompilationInfo* info) { 431 bool UseIgnition(CompilationInfo* info) {
432 if (info->is_debug()) return false; 432 if (info->is_debug()) return false;
433 if (info->shared_info()->is_resumable() && !FLAG_ignition_generators) { 433 if (info->shared_info()->is_resumable() && !FLAG_ignition_generators) {
434 return false; 434 return false;
435 } 435 }
436 436
437 // Since we can't OSR from Ignition, skip Ignition for asm.js functions.
438 if (info->shared_info()->asm_function()) {
439 return false;
440 }
441
437 // Checks whether top level functions should be passed by the filter. 442 // Checks whether top level functions should be passed by the filter.
438 if (info->shared_info()->is_toplevel()) { 443 if (info->shared_info()->is_toplevel()) {
439 Vector<const char> filter = CStrVector(FLAG_ignition_filter); 444 Vector<const char> filter = CStrVector(FLAG_ignition_filter);
440 return (filter.length() == 0) || (filter.length() == 1 && filter[0] == '*'); 445 return (filter.length() == 0) || (filter.length() == 1 && filter[0] == '*');
441 } 446 }
442 447
443 // Finally respect the filter. 448 // Finally respect the filter.
444 return info->shared_info()->PassesFilter(FLAG_ignition_filter); 449 return info->shared_info()->PassesFilter(FLAG_ignition_filter);
445 } 450 }
446 451
(...skipping 1346 matching lines...) Expand 10 before | Expand all | Expand 10 after
1793 MaybeHandle<Code> code; 1798 MaybeHandle<Code> code;
1794 if (cached.code != nullptr) code = handle(cached.code); 1799 if (cached.code != nullptr) code = handle(cached.code);
1795 Handle<Context> native_context(function->context()->native_context()); 1800 Handle<Context> native_context(function->context()->native_context());
1796 SharedFunctionInfo::AddToOptimizedCodeMap(shared, native_context, code, 1801 SharedFunctionInfo::AddToOptimizedCodeMap(shared, native_context, code,
1797 literals, BailoutId::None()); 1802 literals, BailoutId::None());
1798 } 1803 }
1799 } 1804 }
1800 1805
1801 } // namespace internal 1806 } // namespace internal
1802 } // namespace v8 1807 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698