Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1994203003: Apply scroll offset and content box offset before recursing in mapAncestorToLocal (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply scroll offset and content box offset before recursing in mapAncestorToLocal The way mapAncestorToLocal works is to compute a localToAncestor transform, then invert it at the end. Thus the incremental pieces of the transforms must be applied bottom-up. Also clean up a few places where scrollOffset() is simpler to use than scrollPosition. BUG=607565 Committed: https://crrev.com/2ea2924dc159391166a1b42008f576a501e42ea3 Cr-Commit-Position: refs/heads/master@{#394922}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
chrishtr
4 years, 7 months ago (2016-05-19 21:29:52 UTC) #4
Xianzhu
lgtm
4 years, 7 months ago (2016-05-19 21:32:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994203003/20001
4 years, 7 months ago (2016-05-19 21:33:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 00:17:37 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:19:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ea2924dc159391166a1b42008f576a501e42ea3
Cr-Commit-Position: refs/heads/master@{#394922}

Powered by Google App Engine
This is Rietveld 408576698