Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1994143002: MIPS: Align emitting a trampoline pool to instruction size boundaries. (Closed)

Created:
4 years, 7 months ago by balazs.kilvady
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Align emitting a trampoline pool to instruction size boundaries. Assembler::db() could start a trampoline pool at wrong pc position. TEST: mjsunit/asm/embenchen/zlib BUG= Committed: https://crrev.com/65aa64ac8de6a35ad9a83e1186183f977ce98ae9 Cr-Commit-Position: refs/heads/master@{#36374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/mips/assembler-mips-inl.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 7 months ago (2016-05-19 12:32:02 UTC) #2
akos.palfi.imgtec
Nice, lgtm!
4 years, 7 months ago (2016-05-19 16:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994143002/1
4 years, 7 months ago (2016-05-19 16:44:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 17:14:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:15:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65aa64ac8de6a35ad9a83e1186183f977ce98ae9
Cr-Commit-Position: refs/heads/master@{#36374}

Powered by Google App Engine
This is Rietveld 408576698