add new readPixels with direct memory parameters

bench/PremulAndUnpremulAlphaOpsBench.cpp

Index: bench/PremulAndUnpremulAlphaOpsBench.cpp
diff --git a/bench/PremulAndUnpremulAlphaOpsBench.cpp b/bench/PremulAndUnpremulAlphaOpsBench.cpp
index 4afa43fe6ebfee0c87ba1ce3f03dea70e25dd9d0..8eb90285e147303b97aec16bddc6fcf5ee5935bb 100644
--- a/bench/PremulAndUnpremulAlphaOpsBench.cpp
+++ b/bench/PremulAndUnpremulAlphaOpsBench.cpp
@@ -12,12 +12,16 @@
 #include "sk_tool_utils.h"
 
 class PremulAndUnpremulAlphaOpsBench : public SkBenchmark {
+    enum {
+        W = 256,
+        H = 256,
+    };
+    SkBitmap fBmp1, fBmp2;
+    
 public:
-    PremulAndUnpremulAlphaOpsBench(SkCanvas::Config8888 config) {
-        fUnPremulConfig = config;
-        fName.printf("premul_and_unpremul_alpha_%s",
-                     (config ==  SkCanvas::kRGBA_Unpremul_Config8888) ?
-                     "RGBA8888" : "Native8888");
+    PremulAndUnpremulAlphaOpsBench(SkColorType ct) {
+        fColorType = ct;
+        fName.printf("premul_and_unpremul_alpha_%s", sk_tool_utils::colortype_name(ct));
     }
 
 protected:
@@ -25,47 +29,38 @@ protected:
         return fName.c_str();
     }
 
-    virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
-        canvas->clear(SK_ColorBLACK);
-        SkISize size = canvas->getDeviceSize();
+    virtual void onPreDraw() {
+        SkImageInfo info = SkImageInfo::Make(W, H, fColorType, kPremul_SkAlphaType);
+        fBmp1.allocPixels(info);   // used in writePixels
 
-        SkBitmap bmp1;
-        bmp1.setConfig(SkBitmap::kARGB_8888_Config, size.width(),
-                       size.height());
-        bmp1.allocPixels();
-        SkAutoLockPixels alp(bmp1);
-        uint32_t* pixels = reinterpret_cast<uint32_t*>(bmp1.getPixels());
-        for (int h = 0; h < size.height(); ++h) {
-            for (int w = 0; w < size.width(); ++w)
-                pixels[h * size.width() + w] = SkPackConfig8888(fUnPremulConfig,
-                    h & 0xFF, w & 0xFF, w & 0xFF, w & 0xFF);
+        for (int h = 0; h < H; ++h) {
+            for (int w = 0; w < W; ++w) {
+                // SkColor places A in the right slot for either RGBA or BGRA
+                *fBmp1.getAddr32(w, h) = SkColorSetARGB(h & 0xFF, w & 0xFF, w & 0xFF, w & 0xFF);

[scroggo, 2014/07/11 15:21:25]

Can't this result in an invalid premultiplied color? e.g. for the upper right
hand corner (w=W-1, h=0), the color will be:

a=0, r=255, g=255, h=255

I'm guessing this is the cause of
http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug...

[bsalomon, 2014/07/11 15:30:39]

Yeah, I think the intention was for bmp1 to be unpremul and bmp2 to be premul.
That would make the comments in the onDraw() loop make sense.

+            }
         }
+        
+        fBmp2.allocPixels(info);    // used in readPixels()
+    }
 
-        SkBitmap bmp2;
-        bmp2.setConfig(SkBitmap::kARGB_8888_Config, size.width(),
-                       size.height());
-
-        SkColorType ct;
-        SkAlphaType at;
-        sk_tool_utils::config8888_to_imagetypes(fUnPremulConfig, &ct, &at);
-        if (bmp1.isOpaque()) {
-            at = kOpaque_SkAlphaType;
-        }
+    virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
+        canvas->clear(SK_ColorBLACK);
 
         for (int loop = 0; loop < loops; ++loop) {
             // Unpremul -> Premul
-            sk_tool_utils::write_pixels(canvas, bmp1, 0, 0, ct, at);
+            canvas->writePixels(fBmp1.info(), fBmp1.getPixels(), fBmp1.rowBytes(), 0, 0);
             // Premul -> Unpremul
-            canvas->readPixels(&bmp2, 0, 0, fUnPremulConfig);
+            canvas->readPixels(fBmp2.info(), fBmp2.getPixels(), fBmp2.rowBytes(), 0, 0);
         }
     }
 
 private:
-    SkCanvas::Config8888 fUnPremulConfig;
+    SkColorType fColorType;
     SkString fName;
+
     typedef SkBenchmark INHERITED;
 };
 
 
-DEF_BENCH(return new PremulAndUnpremulAlphaOpsBench(SkCanvas::kRGBA_Unpremul_Config8888));
-DEF_BENCH(return new PremulAndUnpremulAlphaOpsBench(SkCanvas::kNative_Unpremul_Config8888));
+DEF_BENCH(return new PremulAndUnpremulAlphaOpsBench(kRGBA_8888_SkColorType));
+DEF_BENCH(return new PremulAndUnpremulAlphaOpsBench(kBGRA_8888_SkColorType));