Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 199413010: win: make msvs_shard work properly for static_library references (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

win: make msvs_shard work properly for static_library references Before this, dependencies inside a static_library weren't updated to reference the _N targets, necessitating workarounds like https://src.chromium.org/viewvc/chrome?revision=254345&view=revision . The 'refs_to_shard_external_lib' target fails before this change. R=thakis@chromium.org BUG=chromium:352495 Committed: https://code.google.com/p/gyp/source/detail?r=1873

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : dll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -11 lines) Patch
M pylib/gyp/MSVSUtil.py View 2 chunks +11 lines, -10 lines 0 comments Download
M test/win/gyptest-link-shard.py View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/win/shard/hello.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/win/shard/shard.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
A test/win/shard/shard_ref.gyp View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 9 months ago (2014-03-14 16:36:54 UTC) #1
Nico
lgtm This is enables removing browser_real which is great, but it's not needed for the ...
6 years, 9 months ago (2014-03-14 16:48:48 UTC) #2
scottmg
On 2014/03/14 16:48:48, Nico wrote: > lgtm > > This is enables removing browser_real which ...
6 years, 9 months ago (2014-03-14 17:00:15 UTC) #3
scottmg
On 2014/03/14 17:00:15, scottmg wrote: > On 2014/03/14 16:48:48, Nico wrote: > > lgtm > ...
6 years, 9 months ago (2014-03-14 17:00:45 UTC) #4
scottmg
On 2014/03/14 17:00:15, scottmg wrote: > On 2014/03/14 16:48:48, Nico wrote: > > lgtm > ...
6 years, 9 months ago (2014-03-14 17:37:49 UTC) #5
scottmg
6 years, 9 months ago (2014-03-14 17:38:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r1873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698