Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 199413008: Simplify MediaControls::show() and hide() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControls.cpp
diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp
index 2af3e93524f5377ae83bfa9e3f968527fd9c6192..f4ae8fe9c2c1a91dbf4d652859cc59805c56cd29 100644
--- a/Source/core/html/shadow/MediaControls.cpp
+++ b/Source/core/html/shadow/MediaControls.cpp
@@ -27,6 +27,7 @@
#include "config.h"
#include "core/html/shadow/MediaControls.h"
+#include "HTMLNames.h"
#include "bindings/v8/ExceptionStatePlaceholder.h"
#include "core/events/MouseEvent.h"
#include "core/html/HTMLMediaElement.h"
@@ -201,15 +202,13 @@ void MediaControls::reset()
void MediaControls::show()
{
+ setBooleanAttribute(HTMLNames::hiddenAttr, false);
makeOpaque();
- m_panel->setIsDisplayed(true);
- m_panel->show();
}
void MediaControls::hide()
{
- m_panel->setIsDisplayed(false);
- m_panel->hide();
+ setBooleanAttribute(HTMLNames::hiddenAttr, true);
}
void MediaControls::makeOpaque()
« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698