Issue 199413008: Simplify MediaControls::show() and hide()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199413008: Simplify MediaControls::show() and hide() (Closed)

Created:
6 years, 9 months ago by philipj_slow

Modified:
6 years, 9 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify MediaControls::show() and hide() By hiding the entire HTMLDivElement that is MediaControls, there's no need to worry about the state of the child elements. As a possible optimization, one could expose a bool hidden() and let HTMLMediaElement not update controls when they are hidden, but that would be more code to test for no obvious gain. BUG=341813, 347105 TEST=LayoutTests/media/ pass; no observable change expected

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -15 lines)			Patch
M	Source/core/html/shadow/MediaControlElements.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/shadow/MediaControlElements.cpp	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	Source/core/html/shadow/MediaControls.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

These changes look ok, but doesn't this potentially hide the text cues?

6 years, 9 months ago (2014-03-17 23:47:45 UTC) #1

philipj_slow

6 years, 9 months ago (2014-03-18 03:10:47 UTC) #2

Heh, I don't know how I could overlook that. You're right, this just doesn't
work, at least not until text track rendering is refactored out of the controls
code, which is something I'd like to do. For now, though, I guess just hiding
the top-level containers inside the controls is the way to go.

Expand Messages | Collapse Messages