Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 1994093002: Introduce CustomElementRegistry#get() method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-05-31T14:40:56 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
index e410349ac24f66484daacbb7c199e68be1822b60..04197473208f283a648134871b46914dc8134fd9 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
@@ -12,6 +12,9 @@
namespace blink {
+class ScriptState;
+class ScriptValue;
dominicc (has gone to gerrit) 2016/05/31 06:01:50 Is it possible to return by value without a comple
yosin_UTC9 2016/05/31 09:16:57 It works, but users of CED needs to include "Scrip
+
class CORE_EXPORT CustomElementDefinition
: public GarbageCollectedFinalized<CustomElementDefinition> {
WTF_MAKE_NONCOPYABLE(CustomElementDefinition);
@@ -21,6 +24,8 @@ public:
const CustomElementDescriptor& descriptor() { return m_descriptor; }
+ virtual ScriptValue getConstructor(ScriptState*) = 0;
dominicc (has gone to gerrit) 2016/05/31 06:01:51 Write a C++ unit test that exercises this.
yosin_UTC9 2016/05/31 09:16:57 Since, getConstructor() is used for implementing C
+
DEFINE_INLINE_VIRTUAL_TRACE() { }
private:

Powered by Google App Engine
This is Rietveld 408576698