Introduce CustomElementRegistry#get() method

third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CustomElementDefinition_h
 #define CustomElementDefinition_h
 
+#include "bindings/core/v8/ScriptValue.h"
 #include "core/CoreExport.h"
 #include "core/dom/custom/CustomElementDescriptor.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Noncopyable.h"
 
 namespace blink {
 
+class ScriptState;
+
 class CORE_EXPORT CustomElementDefinition
     : public GarbageCollectedFinalized<CustomElementDefinition> {
     WTF_MAKE_NONCOPYABLE(CustomElementDefinition);
 public:
     CustomElementDefinition(const CustomElementDescriptor&);
     virtual ~CustomElementDefinition();
 
     const CustomElementDescriptor& descriptor() { return m_descriptor; }
 
+    // TODO(yosin): We should ask binding layer to convert C++ constructor

[dominicc (has gone to gerrit), 2016/05/31 22:56:32]

This TODO covers "what"--ask the binding layer to convert C++ constructors.

What's missing is a "when" and/or "why". Try to include some detail that's the
trigger condition, so a knowledgable reader can say "ah, we can fix this TODO
now" or "no, this is still blocked because X."

+    // value to ScriptValue, e.g. introduce |CustomElementConsturcotr|

[dominicc (has gone to gerrit), 2016/05/31 22:56:32]

spelling: constructor

[yosin_UTC9, 2016/06/01 02:14:37]

Done.

+    // class with |ScripttCustomElementConsturcotr|

[dominicc (has gone to gerrit), 2016/05/31 22:56:32]

spelling: script, constructor

[yosin_UTC9, 2016/06/01 02:14:37]

Done.

+    virtual ScriptValue getConstructor(ScriptState*) = 0;

[dominicc (has gone to gerrit), 2016/05/31 22:56:32]

What do you think about calling this getConstructorForScript or
getScriptConstructor? This method is all about interfacing with JavaScript, we
may as well put it right in the name.

[yosin_UTC9, 2016/06/01 02:14:37]

Done. Use getConstructorForScript()

+
     DEFINE_INLINE_VIRTUAL_TRACE() { }
 
 private:
     const CustomElementDescriptor m_descriptor;
 };
 
 } // namespace blink
 
 #endif // CustomElementDefinition_h