third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.idl - Issue 1994093002: Introduce CustomElementRegistry#get() method

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.idl

Issue 1994093002: Introduce CustomElementRegistry#get() method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-31T14:40:56 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 RuntimeEnabled=CustomElementsV1,	6 RuntimeEnabled=CustomElementsV1,

7 ] interface CustomElementsRegistry {	7 ] interface CustomElementsRegistry {

8 [CallWith=ScriptState, CustomElementCallbacks, RaisesException] void define( DOMString name, Function constructor, optional ElementRegistrationOptions option s);	8 [CallWith=ScriptState, CustomElementCallbacks, RaisesException] void define( DOMString name, Function constructor, optional ElementRegistrationOptions option s);

	9 [CallWith=ScriptState]
	dominicc (has gone to gerrit) 2016/05/31 06:01:51 I don't think we need CallWith=ScriptState; Script I don't think we need CallWith=ScriptState; ScriptCustomElementDefinition can cache the ScriptState and use that. yosin_UTC9 2016/05/31 09:16:57 I need to return \|undefined\| value, when there is Show quoted text On 2016/05/31 at 06:01:51, dominicc wrote: > I don't think we need CallWith=ScriptState; ScriptCustomElementDefinition can cache the ScriptState and use that. I need to return \|undefined\| value, when there is no definition for name as \|ScriptValue(scriptState, v8Undefined())\|. Cached ScriptValue in ScriptCustomElementDefinition will be used for context checking.
	10 any get(DOMString name);

9 };	11 };

OLD	NEW