Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1994083003: Adding x64 simd assembler support. (Closed)

Created:
4 years, 7 months ago by bradnelson
Modified:
4 years, 7 months ago
Reviewers:
titzer, bbudge, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding x64 simd assembler support. Based on assembler changes from this patch: https://codereview.chromium.org/90643003/ BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 R=titzer@chromium.org,bbudge@chromium.org LOG=N Committed: https://crrev.com/fd39fdc5fb7cb78497b7382b5c33dfaedffc6721 Cr-Commit-Position: refs/heads/master@{#36383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -7 lines) Patch
M src/x64/assembler-x64.h View 2 chunks +40 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 4 chunks +305 lines, -0 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +38 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bradn
4 years, 7 months ago (2016-05-19 08:41:24 UTC) #2
titzer
On 2016/05/19 08:41:24, bradn wrote: lgtm
4 years, 7 months ago (2016-05-19 08:56:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994083003/1
4 years, 7 months ago (2016-05-19 19:51:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 19:53:06 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:54:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd39fdc5fb7cb78497b7382b5c33dfaedffc6721
Cr-Commit-Position: refs/heads/master@{#36383}

Powered by Google App Engine
This is Rietveld 408576698