Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

BUG=611953
Committed: https://crrev.com/1809440f3119353a14bbe1b4b1500c817c2710ce
Cr-Commit-Position: refs/heads/master@{#395024}

[dominicc (has gone to gerrit), 2016-05-19 07:52:48]

dominicc@chromium.org changed reviewers:
+ scottmg@chromium.org

[dominicc (has gone to gerrit), 2016-05-19 08:00:55]

PTAL

Previously I was exporting the upstream git repo into third_party/libxml.
Running autogen injected a spurious COPYING file.

Now I build a dist tarball as an intermediate step; it is this step (make
dist-all) that sets the correct COPYING file up. (The file is called Copyright
in the upstream repo.)

COPYING does not appear in this diff because it hasn't changed; copyright
Viellard etc.

For some traceability I'm starting to automate these rolls a bit; this was
produced by this script in my personal GitHub repo:
https://github.com/dominiccooney/blink-tools/blob/master/roll.py

[scottmg, 2016-05-19 16:24:07]

On 2016/05/19 08:00:55, dominicc wrote:
> PTAL
> 
> Previously I was exporting the upstream git repo into third_party/libxml.
> Running autogen injected a spurious COPYING file.
> 
> Now I build a dist tarball as an intermediate step; it is this step (make
> dist-all) that sets the correct COPYING file up. (The file is called Copyright
> in the upstream repo.)
> 
> COPYING does not appear in this diff because it hasn't changed; copyright
> Viellard etc.
> 
> For some traceability I'm starting to automate these rolls a bit; this was
> produced by this script in my personal GitHub repo:
> https://github.com/dominiccooney/blink-tools/blob/master/roll.py

That sounds great, could you mention that in README.chromium? With that lgtm.

[scottmg, 2016-05-19 16:26:52]

dictionnary!

https://codereview.chromium.org/1994003003/diff/20001/third_party/libxml/mac/...
File third_party/libxml/mac/include/libxml/xmlversion.h (right):

https://codereview.chromium.org/1994003003/diff/20001/third_party/libxml/mac/...
third_party/libxml/mac/include/libxml/xmlversion.h:285: #if 0
Was this intentional? It's 1 on Linux and Win still.

[Dirk Pranke, 2016-05-19 17:17:52]

On 2016/05/19 16:24:07, scottmg wrote:
> On 2016/05/19 08:00:55, dominicc wrote:
> > For some traceability I'm starting to automate these rolls a bit; this was
> > produced by this script in my personal GitHub repo:
> > https://github.com/dominiccooney/blink-tools/blob/master/roll.py
> 
> That sounds great, could you mention that in README.chromium? With that lgtm.

I encourage you to check that into chromium, even.

[dominicc (has gone to gerrit), 2016-05-19 21:07:37]

On 2016/05/19 at 17:17:52, dpranke wrote:
> On 2016/05/19 16:24:07, scottmg wrote:
> > On 2016/05/19 08:00:55, dominicc wrote:
> > > For some traceability I'm starting to automate these rolls a bit; this was
> > > produced by this script in my personal GitHub repo:
> > > https://github.com/dominiccooney/blink-tools/blob/master/roll.py
> > 
> > That sounds great, could you mention that in README.chromium? With that
lgtm.
> 
> I encourage you to check that into chromium, even.

OK, let me work on that in a follow-up. The script is pretty rough ATM.

[dominicc (has gone to gerrit), 2016-05-19 21:08:32]

On 2016/05/19 at 16:26:52, scottmg wrote:
> dictionnary!
> 
>
https://codereview.chromium.org/1994003003/diff/20001/third_party/libxml/mac/...
> File third_party/libxml/mac/include/libxml/xmlversion.h (right):
> 
>
https://codereview.chromium.org/1994003003/diff/20001/third_party/libxml/mac/...
> third_party/libxml/mac/include/libxml/xmlversion.h:285: #if 0
> Was this intentional? It's 1 on Linux and Win still.

Gah, good catch, no; no intentional. I brought up a new OS X box and it is
obviously not set up right.

[dominicc (has gone to gerrit), 2016-05-19 21:39:07]

Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

[dominicc (has gone to gerrit), 2016-05-19 21:51:07]

PTAL

I put a link to the github commit with of the draft roll script in
README.chromium and I'll work on committing that separately since it will need
quite some work. I should incorporate more sanity checks like ICU being enabled
and ICONV being disabled; these rolls aren't very 'hermetic.' But it's a start.

[scottmg, 2016-05-19 21:58:46]

lgtm

[dominicc (has gone to gerrit), 2016-05-20 06:37:18]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2016-05-20 06:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994003003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994003003/60001

[commit-bot: I haz the power, 2016-05-20 07:12:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-20 07:14:12]

Description was changed from

==========
Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

BUG=611953
==========

to

==========
Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

BUG=611953

Committed: https://crrev.com/1809440f3119353a14bbe1b4b1500c817c2710ce
Cr-Commit-Position: refs/heads/master@{#395024}
==========

[commit-bot: I haz the power, 2016-05-20 07:14:13]

Patchset 4 (id:??) landed as
https://crrev.com/1809440f3119353a14bbe1b4b1500c817c2710ce
Cr-Commit-Position: refs/heads/master@{#395024}