Subzero, MIPS32: Introduction of floating point registers

src/IceInstMIPS32.h

 //===- subzero/src/IceInstMIPS32.h - MIPS32 machine instrs --*- C++ -*-===    //
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 109 matching lines @@
     Add,
     Addiu,
     Addu,
     And,
     Andi,
     Br,
     Call,
     La,
     Label,
     Lui,
+    Mfc1,
     Mfhi,
     Mflo,
     Mov, // actually a pseudo op for addi rd, rs, 0
+    Mtc1,
     Mthi,
     Mtlo,
     Mul,
     Mult,
     Multu,
     Or,
     Ori,
     Ret,
     Sll,
     Sllv,
@@ skipping 22 matching lines @@
   // TODO(rkotler): while branching is not implemented
   bool repointEdges(CfgNode *, CfgNode *) override { return true; }
 
   /// Shared emit routines for common forms of instructions.
   static void emitUnaryopGPR(const char *Opcode, const InstMIPS32 *Inst,
                              const Cfg *Func);
   static void emitUnaryopGPRFLoHi(const char *Opcode, const InstMIPS32 *Inst,
                                   const Cfg *Func);
   static void emitUnaryopGPRTLoHi(const char *Opcode, const InstMIPS32 *Inst,
                                   const Cfg *Func);
+  static void emitTwoAddr(const char *Opcode, const InstMIPS32 *Inst,
+                          const Cfg *Func);
   static void emitThreeAddr(const char *Opcode, const InstMIPS32 *Inst,
                             const Cfg *Func);
   static void emitThreeAddrLoHi(const char *Opcode, const InstMIPS32 *Inst,
                                 const Cfg *Func);
 
 protected:
   InstMIPS32(Cfg *Func, InstKindMIPS32 Kind, SizeT Maxsrcs, Variable *Dest)
       : InstTarget(Func, static_cast<InstKind>(Kind), Maxsrcs, Dest) {}
   static bool isClassof(const Inst *Inst, InstKindMIPS32 MyKind) {
     return Inst->getKind() == static_cast<InstKind>(MyKind);
@@ skipping 64 matching lines @@
 protected:
   InstMIPS32UnaryopGPR(Cfg *Func, Variable *Dest, Operand *Src)
       : InstMIPS32(Func, K, 1, Dest) {
     addSource(Src);
   }
 
 private:
   static const char *Opcode;
 };
 
+/// Instructions of the form opcode reg, reg.
+template <InstMIPS32::InstKindMIPS32 K>
+class InstMIPS32TwoAddrGPR : public InstMIPS32 {
+  InstMIPS32TwoAddrGPR() = delete;
+  InstMIPS32TwoAddrGPR(const InstMIPS32TwoAddrGPR &) = delete;
+  InstMIPS32TwoAddrGPR &operator=(const InstMIPS32TwoAddrGPR &) = delete;
+
+public:
+  static InstMIPS32TwoAddrGPR *create(Cfg *Func, Variable *Dest,
+                                        Variable *Src0) {
+    return new (Func->allocate<InstMIPS32TwoAddrGPR>())
+        InstMIPS32TwoAddrGPR(Func, Dest, Src0);
+  }
+  void emit(const Cfg *Func) const override {
+    if (!BuildDefs::dump())
+      return;
+    emitTwoAddr(Opcode, this, Func);
+  }
+  void emitIAS(const Cfg *Func) const override {
+    (void)Func;
+    llvm_unreachable("Not yet implemented");
+  }
+
+  void dump(const Cfg *Func) const override {
+    if (!BuildDefs::dump())
+      return;
+    Ostream &Str = Func->getContext()->getStrDump();
+    dumpDest(Func);
+    Str << " = ";
+    dumpOpcode(Str, Opcode, getDest()->getType());
+    Str << " ";
+    dumpSources(Func);
+  }
+  static bool classof(const Inst *Inst) { return isClassof(Inst, K); }
+
+private:
+  InstMIPS32TwoAddrGPR(Cfg *Func, Variable *Dest, Variable *Src0)
+      : InstMIPS32(Func, K, 2, Dest) {

[Jim Stichnoth, 2016/05/19 23:12:25]

The "2" is the max number of src operands.  I think it should be 1 here since
there is just a single addSource() call, also the emit routine asserts there is
just one src operand.

(This is in contrast to 2-operand instructions where one operand doubles as the
dest variable, like "opc a, b" with semantics "a = a opc b", in which case the
dest variable also needs to be added as a src operand.)

[obucinac, 2016/05/27 11:13:18]

Done.

+    addSource(Src0);
+  }
+
+  static const char *Opcode;
+};
+
 /// Instructions of the form x := y op z. May have the side-effect of setting
 /// status flags.
 template <InstMIPS32::InstKindMIPS32 K>
 class InstMIPS32ThreeAddrGPR : public InstMIPS32 {
   InstMIPS32ThreeAddrGPR() = delete;
   InstMIPS32ThreeAddrGPR(const InstMIPS32ThreeAddrGPR &) = delete;
   InstMIPS32ThreeAddrGPR &operator=(const InstMIPS32ThreeAddrGPR &) = delete;
 
 public:
   /// Create an ordinary binary-op instruction like add, and sub. Dest and Src1
@@ skipping 196 matching lines @@
   const uint32_t Imm;
 };
 
 using InstMIPS32Add = InstMIPS32ThreeAddrGPR<InstMIPS32::Add>;
 using InstMIPS32Addu = InstMIPS32ThreeAddrGPR<InstMIPS32::Addu>;
 using InstMIPS32Addiu = InstMIPS32Imm16<InstMIPS32::Addiu, true>;
 using InstMIPS32And = InstMIPS32ThreeAddrGPR<InstMIPS32::And>;
 using InstMIPS32Andi = InstMIPS32Imm16<InstMIPS32::Andi>;
 using InstMIPS32Lui = InstMIPS32Imm16<InstMIPS32::Lui>;
 using InstMIPS32La = InstMIPS32UnaryopGPR<InstMIPS32::La>;
+using InstMIPS32Mfc1 = InstMIPS32TwoAddrGPR<InstMIPS32::Mfc1>;
 using InstMIPS32Mfhi = InstMIPS32UnaryopGPR<InstMIPS32::Mfhi>;
 using InstMIPS32Mflo = InstMIPS32UnaryopGPR<InstMIPS32::Mflo>;
+using InstMIPS32Mtc1 = InstMIPS32TwoAddrGPR<InstMIPS32::Mtc1>;
 using InstMIPS32Mthi = InstMIPS32UnaryopGPR<InstMIPS32::Mthi>;
 using InstMIPS32Mtlo = InstMIPS32UnaryopGPR<InstMIPS32::Mtlo>;
 using InstMIPS32Mul = InstMIPS32ThreeAddrGPR<InstMIPS32::Mul>;
 using InstMIPS32Mult = InstMIPS32ThreeAddrGPR<InstMIPS32::Mult>;
 using InstMIPS32Multu = InstMIPS32ThreeAddrGPR<InstMIPS32::Multu>;
 using InstMIPS32Or = InstMIPS32ThreeAddrGPR<InstMIPS32::Or>;
 using InstMIPS32Ori = InstMIPS32Imm16<InstMIPS32::Ori>;
 using InstMIPS32Sll = InstMIPS32Imm16<InstMIPS32::Sll>;
 using InstMIPS32Sllv = InstMIPS32ThreeAddrGPR<InstMIPS32::Sllv>;
 using InstMIPS32Slt = InstMIPS32ThreeAddrGPR<InstMIPS32::Slt>;
@@ skipping 57 matching lines @@
 template <> void InstMIPS32Mfhi::emit(const Cfg *Func) const;
 template <> void InstMIPS32Mtlo::emit(const Cfg *Func) const;
 template <> void InstMIPS32Mthi::emit(const Cfg *Func) const;
 template <> void InstMIPS32Mult::emit(const Cfg *Func) const;
 template <> void InstMIPS32Multu::emit(const Cfg *Func) const;
 
 } // end of namespace MIPS32
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEINSTMIPS32_H