Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: components/offline_pages/offline_page_metadata_store_impl_unittest.cc

Issue 1993953002: [Offline pages] Adding expiration capability to OfflinePageModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_metadata_store.h" 5 #include "components/offline_pages/offline_page_metadata_store.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 EXPECT_EQ(STATUS_TRUE, this->last_status_); 172 EXPECT_EQ(STATUS_TRUE, this->last_status_);
173 EXPECT_EQ(1U, this->offline_pages_.size()); 173 EXPECT_EQ(1U, this->offline_pages_.size());
174 EXPECT_EQ(offline_page.url, this->offline_pages_[0].url); 174 EXPECT_EQ(offline_page.url, this->offline_pages_[0].url);
175 EXPECT_EQ(offline_page.offline_id, this->offline_pages_[0].offline_id); 175 EXPECT_EQ(offline_page.offline_id, this->offline_pages_[0].offline_id);
176 EXPECT_EQ(offline_page.version, this->offline_pages_[0].version); 176 EXPECT_EQ(offline_page.version, this->offline_pages_[0].version);
177 EXPECT_EQ(offline_page.file_path, this->offline_pages_[0].file_path); 177 EXPECT_EQ(offline_page.file_path, this->offline_pages_[0].file_path);
178 EXPECT_EQ(offline_page.file_size, this->offline_pages_[0].file_size); 178 EXPECT_EQ(offline_page.file_size, this->offline_pages_[0].file_size);
179 EXPECT_EQ(offline_page.creation_time, this->offline_pages_[0].creation_time); 179 EXPECT_EQ(offline_page.creation_time, this->offline_pages_[0].creation_time);
180 EXPECT_EQ(offline_page.last_access_time, 180 EXPECT_EQ(offline_page.last_access_time,
181 this->offline_pages_[0].last_access_time); 181 this->offline_pages_[0].last_access_time);
182 EXPECT_EQ(offline_page.expiration_time,
183 this->offline_pages_[0].expiration_time);
182 EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count); 184 EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count);
183 EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id); 185 EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id);
184 } 186 }
185 187
186 // Tests removing offline page metadata from the store, for which it first adds 188 // Tests removing offline page metadata from the store, for which it first adds
187 // metadata of an offline page. 189 // metadata of an offline page.
188 TYPED_TEST(OfflinePageMetadataStoreTest, RemoveOfflinePage) { 190 TYPED_TEST(OfflinePageMetadataStoreTest, RemoveOfflinePage) {
189 std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore()); 191 std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore());
190 192
191 // Add an offline page. 193 // Add an offline page.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore()); 245 std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore());
244 246
245 // Add an offline page. 247 // Add an offline page.
246 OfflinePageItem offline_page_1(GURL(kTestURL), 12345LL, kTestClientId1, 248 OfflinePageItem offline_page_1(GURL(kTestURL), 12345LL, kTestClientId1,
247 base::FilePath(kFilePath), kFileSize); 249 base::FilePath(kFilePath), kFileSize);
248 base::FilePath file_path_2 = 250 base::FilePath file_path_2 =
249 base::FilePath(FILE_PATH_LITERAL("//other.page.com.mhtml")); 251 base::FilePath(FILE_PATH_LITERAL("//other.page.com.mhtml"));
250 OfflinePageItem offline_page_2(GURL("https://other.page.com"), 5678LL, 252 OfflinePageItem offline_page_2(GURL("https://other.page.com"), 5678LL,
251 kTestClientId2, file_path_2, 12345, 253 kTestClientId2, file_path_2, 12345,
252 base::Time::Now()); 254 base::Time::Now());
255 offline_page_2.expiration_time = base::Time::Now();
253 store->AddOrUpdateOfflinePage( 256 store->AddOrUpdateOfflinePage(
254 offline_page_1, 257 offline_page_1,
255 base::Bind(&OfflinePageMetadataStoreTestBase::UpdateCallback, 258 base::Bind(&OfflinePageMetadataStoreTestBase::UpdateCallback,
256 base::Unretained(this), ADD)); 259 base::Unretained(this), ADD));
257 this->PumpLoop(); 260 this->PumpLoop();
258 EXPECT_EQ(ADD, this->last_called_callback_); 261 EXPECT_EQ(ADD, this->last_called_callback_);
259 EXPECT_EQ(STATUS_TRUE, this->last_status_); 262 EXPECT_EQ(STATUS_TRUE, this->last_status_);
260 263
261 this->ClearResults(); 264 this->ClearResults();
262 265
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 EXPECT_EQ(1U, this->offline_pages_.size()); 308 EXPECT_EQ(1U, this->offline_pages_.size());
306 EXPECT_EQ(offline_page_2.url, this->offline_pages_[0].url); 309 EXPECT_EQ(offline_page_2.url, this->offline_pages_[0].url);
307 EXPECT_EQ(offline_page_2.offline_id, this->offline_pages_[0].offline_id); 310 EXPECT_EQ(offline_page_2.offline_id, this->offline_pages_[0].offline_id);
308 EXPECT_EQ(offline_page_2.version, this->offline_pages_[0].version); 311 EXPECT_EQ(offline_page_2.version, this->offline_pages_[0].version);
309 EXPECT_EQ(offline_page_2.file_path, this->offline_pages_[0].file_path); 312 EXPECT_EQ(offline_page_2.file_path, this->offline_pages_[0].file_path);
310 EXPECT_EQ(offline_page_2.file_size, this->offline_pages_[0].file_size); 313 EXPECT_EQ(offline_page_2.file_size, this->offline_pages_[0].file_size);
311 EXPECT_EQ(offline_page_2.creation_time, 314 EXPECT_EQ(offline_page_2.creation_time,
312 this->offline_pages_[0].creation_time); 315 this->offline_pages_[0].creation_time);
313 EXPECT_EQ(offline_page_2.last_access_time, 316 EXPECT_EQ(offline_page_2.last_access_time,
314 this->offline_pages_[0].last_access_time); 317 this->offline_pages_[0].last_access_time);
318 EXPECT_EQ(offline_page_2.expiration_time,
319 this->offline_pages_[0].expiration_time);
315 EXPECT_EQ(offline_page_2.access_count, this->offline_pages_[0].access_count); 320 EXPECT_EQ(offline_page_2.access_count, this->offline_pages_[0].access_count);
316 EXPECT_EQ(offline_page_2.client_id, this->offline_pages_[0].client_id); 321 EXPECT_EQ(offline_page_2.client_id, this->offline_pages_[0].client_id);
317 } 322 }
318 323
319 // Tests updating offline page metadata from the store. 324 // Tests updating offline page metadata from the store.
320 TYPED_TEST(OfflinePageMetadataStoreTest, UpdateOfflinePage) { 325 TYPED_TEST(OfflinePageMetadataStoreTest, UpdateOfflinePage) {
321 std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore()); 326 std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore());
322 327
323 // First, adds a fresh page. 328 // First, adds a fresh page.
324 OfflinePageItem offline_page(GURL(kTestURL), 1234LL, kTestClientId1, 329 OfflinePageItem offline_page(GURL(kTestURL), 1234LL, kTestClientId1,
(...skipping 15 matching lines...) Expand all
340 EXPECT_EQ(STATUS_TRUE, this->last_status_); 345 EXPECT_EQ(STATUS_TRUE, this->last_status_);
341 EXPECT_EQ(1U, this->offline_pages_.size()); 346 EXPECT_EQ(1U, this->offline_pages_.size());
342 EXPECT_EQ(offline_page.url, this->offline_pages_[0].url); 347 EXPECT_EQ(offline_page.url, this->offline_pages_[0].url);
343 EXPECT_EQ(offline_page.offline_id, this->offline_pages_[0].offline_id); 348 EXPECT_EQ(offline_page.offline_id, this->offline_pages_[0].offline_id);
344 EXPECT_EQ(offline_page.version, this->offline_pages_[0].version); 349 EXPECT_EQ(offline_page.version, this->offline_pages_[0].version);
345 EXPECT_EQ(offline_page.file_path, this->offline_pages_[0].file_path); 350 EXPECT_EQ(offline_page.file_path, this->offline_pages_[0].file_path);
346 EXPECT_EQ(offline_page.file_size, this->offline_pages_[0].file_size); 351 EXPECT_EQ(offline_page.file_size, this->offline_pages_[0].file_size);
347 EXPECT_EQ(offline_page.creation_time, this->offline_pages_[0].creation_time); 352 EXPECT_EQ(offline_page.creation_time, this->offline_pages_[0].creation_time);
348 EXPECT_EQ(offline_page.last_access_time, 353 EXPECT_EQ(offline_page.last_access_time,
349 this->offline_pages_[0].last_access_time); 354 this->offline_pages_[0].last_access_time);
355 EXPECT_EQ(offline_page.expiration_time,
356 this->offline_pages_[0].expiration_time);
350 EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count); 357 EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count);
351 EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id); 358 EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id);
352 359
353 // Then update some data. 360 // Then update some data.
354 offline_page.file_size = kFileSize + 1; 361 offline_page.file_size = kFileSize + 1;
355 offline_page.access_count++; 362 offline_page.access_count++;
363 offline_page.expiration_time = base::Time::Now();
356 store->AddOrUpdateOfflinePage( 364 store->AddOrUpdateOfflinePage(
357 offline_page, 365 offline_page,
358 base::Bind(&OfflinePageMetadataStoreTestBase::UpdateCallback, 366 base::Bind(&OfflinePageMetadataStoreTestBase::UpdateCallback,
359 base::Unretained(this), ADD)); 367 base::Unretained(this), ADD));
360 this->PumpLoop(); 368 this->PumpLoop();
361 EXPECT_EQ(ADD, this->last_called_callback_); 369 EXPECT_EQ(ADD, this->last_called_callback_);
362 EXPECT_EQ(STATUS_TRUE, this->last_status_); 370 EXPECT_EQ(STATUS_TRUE, this->last_status_);
363 371
364 this->ClearResults(); 372 this->ClearResults();
365 store->Load(base::Bind(&OfflinePageMetadataStoreTestBase::LoadCallback, 373 store->Load(base::Bind(&OfflinePageMetadataStoreTestBase::LoadCallback,
366 base::Unretained(this))); 374 base::Unretained(this)));
367 this->PumpLoop(); 375 this->PumpLoop();
368 376
369 EXPECT_EQ(LOAD, this->last_called_callback_); 377 EXPECT_EQ(LOAD, this->last_called_callback_);
370 EXPECT_EQ(STATUS_TRUE, this->last_status_); 378 EXPECT_EQ(STATUS_TRUE, this->last_status_);
371 EXPECT_EQ(1U, this->offline_pages_.size()); 379 EXPECT_EQ(1U, this->offline_pages_.size());
372 EXPECT_EQ(offline_page.url, this->offline_pages_[0].url); 380 EXPECT_EQ(offline_page.url, this->offline_pages_[0].url);
373 EXPECT_EQ(offline_page.offline_id, this->offline_pages_[0].offline_id); 381 EXPECT_EQ(offline_page.offline_id, this->offline_pages_[0].offline_id);
374 EXPECT_EQ(offline_page.version, this->offline_pages_[0].version); 382 EXPECT_EQ(offline_page.version, this->offline_pages_[0].version);
375 EXPECT_EQ(offline_page.file_path, this->offline_pages_[0].file_path); 383 EXPECT_EQ(offline_page.file_path, this->offline_pages_[0].file_path);
376 EXPECT_EQ(offline_page.file_size, this->offline_pages_[0].file_size); 384 EXPECT_EQ(offline_page.file_size, this->offline_pages_[0].file_size);
377 EXPECT_EQ(offline_page.creation_time, this->offline_pages_[0].creation_time); 385 EXPECT_EQ(offline_page.creation_time, this->offline_pages_[0].creation_time);
378 EXPECT_EQ(offline_page.last_access_time, 386 EXPECT_EQ(offline_page.last_access_time,
379 this->offline_pages_[0].last_access_time); 387 this->offline_pages_[0].last_access_time);
388 EXPECT_EQ(offline_page.expiration_time,
389 this->offline_pages_[0].expiration_time);
380 EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count); 390 EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count);
381 EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id); 391 EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id);
382 } 392 }
383 393
384 } // namespace 394 } // namespace
385 } // namespace offline_pages 395 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_item.cc ('k') | components/offline_pages/offline_page_metadata_store_sql.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698