[Offline pages] Adding expiration capability to OfflinePageModel

components/offline_pages/offline_page_model.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 490 matching lines @@
 }
 
 void OfflinePageModel::CheckForExternalFileDeletion() {
   DCHECK(is_loaded_);
 
   archive_manager_->GetAllArchives(
       base::Bind(&OfflinePageModel::ScanForMissingArchiveFiles,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
+void OfflinePageModel::ExpirePages(const std::vector<int64_t>& offline_ids,

[romax, 2016/05/20 19:05:00]

In .h you mentioned to clear files here but seems not doing it?

[fgorski, 2016/05/20 20:54:54]

Step by step. You'll be adding this code and it may better to do it directly
from StorageManager.

+                                   const base::Time& expiration_time) {
+  for (int64_t offline_id : offline_ids) {
+    auto iter = offline_pages_.find(offline_id);
+    if (iter == offline_pages_.end())
+      continue;
+
+    OfflinePageItem offline_page = iter->second;
+    offline_page.expiration_time = expiration_time;
+
+    store_->AddOrUpdateOfflinePage(
+        offline_page, base::Bind(&OfflinePageModel::OnExpirePageDone,
+                                 weak_ptr_factory_.GetWeakPtr(), offline_id,

[bburns, 2016/05/20 18:23:27]

personally, I would place one parameter on each line.

[fgorski, 2016/05/20 20:54:54]

I am with you, it takes running git cl format once to get it back here and I
don't like to argue with machines.

+                                 expiration_time));
+  }
+}
+
+void OfflinePageModel::OnExpirePageDone(int64_t offline_id,
+                                        const base::Time& expiration_time,
+                                        bool success) {
+  // TODO(romax): Report UMA about successful expiration.
+  if (success) {
+    auto iter = offline_pages_.find(offline_id);
+    if (iter != offline_pages_.end())
+      iter->second.expiration_time = expiration_time;
+  }
+}
+
 ClientPolicyController* OfflinePageModel::GetPolicyController() {
   return policy_controller_.get();
 }
 
 OfflinePageMetadataStore* OfflinePageModel::GetStoreForTesting() {
   return store_.get();
 }
 
 OfflinePageStorageManager* OfflinePageModel::GetStorageManager() {
   return storage_manager_.get();
@@ skipping 305 matching lines @@
 void OfflinePageModel::RunWhenLoaded(const base::Closure& task) {
   if (!is_loaded_) {
     delayed_tasks_.push_back(task);
     return;
   }
 
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, task);
 }
 
 }  // namespace offline_pages