[Offline pages] Adding expiration capability to OfflinePageModel

components/offline_pages/offline_page_model.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 197 matching lines @@
   // not found.  See |GetBestPageForOnlineURL| for selection criteria.
   const OfflinePageItem* MaybeGetBestPageForOnlineURL(
       const GURL& online_url) const;
 
   // Checks that all of the offline pages have corresponding offline copies.
   // If a page is discovered to be missing an offline copy, its offline page
   // metadata will be removed and |OfflinePageDeleted| will be sent to model
   // observers.
   void CheckForExternalFileDeletion();
 
+  // Marks pages as expired and removes their respective files from the archive
+  // directory.
+  void ExpirePages(const std::vector<int64_t>& offline_ids,
+                   base::Time expiration_time);

[jianli, 2016/05/19 20:39:54]

nit: const &

[fgorski, 2016/05/20 17:54:23]

Done.

+
   // Returns the policy controller.
   ClientPolicyController* GetPolicyController();
 
   // Methods for testing only:
   OfflinePageMetadataStore* GetStoreForTesting();
 
   OfflinePageStorageManager* GetStorageManager();
 
   bool is_loaded() const;
 
@@ skipping 94 matching lines @@
 
   // Actually does the work of deleting, requires the model is loaded.
   void DoDeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
                                 const DeletePageCallback& callback);
 
   // Similar to DoDeletePagesByOfflineId, does actual work of deleting, and
   // requires that the model is loaded.
   void DoDeletePagesByURLPredicate(const UrlPredicate& predicate,
                                    const DeletePageCallback& callback);
 
+  // Callback completing page expiration.
+  void OnExpirePageDone(int64_t offline_id,
+                        base::Time expiration_time,

[jianli, 2016/05/19 20:39:54]

nit: ditto

[fgorski, 2016/05/20 17:54:23]

Done.

+                        bool success);
+
   void RunWhenLoaded(const base::Closure& job);
 
   // Persistent store for offline page metadata.
   std::unique_ptr<OfflinePageMetadataStore> store_;
 
   // Location where all of the archive files will be stored.
   base::FilePath archives_dir_;
 
   // The observers.
   base::ObserverList<Observer> observers_;
@@ skipping 20 matching lines @@
   std::unique_ptr<ArchiveManager> archive_manager_;
 
   base::WeakPtrFactory<OfflinePageModel> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageModel);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_