Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 1993943002: Move m_lineBoxes and its getters down to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move m_lineBoxes and its getters down to LayoutBlockFlow. Added SameSizeAsLayoutBlockFlow, since it was missing. BUG=302024 Committed: https://crrev.com/be6cc8b3ee9ec912533a2a57a8529f3a524ae0d9 Cr-Commit-Position: refs/heads/master@{#394728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 3 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 3 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mstensho (USE GERRIT)
Need to wait for https://codereview.chromium.org/1993713002/ to land first, though.
4 years, 7 months ago (2016-05-18 21:52:54 UTC) #3
wkorman
lgtm
4 years, 7 months ago (2016-05-18 21:58:02 UTC) #4
eae
LGTM
4 years, 7 months ago (2016-05-19 00:36:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993943002/1
4 years, 7 months ago (2016-05-19 05:25:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224677)
4 years, 7 months ago (2016-05-19 08:52:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993943002/1
4 years, 7 months ago (2016-05-19 09:02:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 10:48:43 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 10:49:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be6cc8b3ee9ec912533a2a57a8529f3a524ae0d9
Cr-Commit-Position: refs/heads/master@{#394728}

Powered by Google App Engine
This is Rietveld 408576698