Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1993913002: [cleanup] Drop FLAG_eliminate_prototype_chain_checks (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Drop FLAG_eliminate_prototype_chain_checks This flag has been on by default for a while, along with FLAG_track_prototype_users which provides the prerequisite infrastructure. We are now sure that this is the direction we want to go in, so in order to simplify the code, this CL drops the respective flag-off code paths. Committed: https://crrev.com/eac1b38d9ae4091fb7feb6568a070273b9483237 Cr-Commit-Position: refs/heads/master@{#36445}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -453 lines) Patch
M src/flag-definitions.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 4 chunks +24 lines, -55 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 4 chunks +24 lines, -56 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 4 chunks +24 lines, -56 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 4 chunks +24 lines, -55 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 4 chunks +24 lines, -55 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 4 chunks +24 lines, -55 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 4 chunks +25 lines, -57 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 4 chunks +24 lines, -56 lines 0 comments Download
M src/objects.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL. If we're going to put cells into the vector, it doesn't make sense any ...
4 years, 7 months ago (2016-05-23 08:57:40 UTC) #2
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-23 13:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993913002/20001
4 years, 7 months ago (2016-05-23 13:53:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 14:25:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:27:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eac1b38d9ae4091fb7feb6568a070273b9483237
Cr-Commit-Position: refs/heads/master@{#36445}

Powered by Google App Engine
This is Rietveld 408576698