Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1993893002: 👾 GN(android): Filter R.class files before obfuscating via proguard (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android): Filter R.class files before obfuscating via proguard I haven't heard of this causing issues for us yet, but I realized that filtering after proguarding could have the result that proguard renames a class to "R.class", and then filtering strips it out. BUG=585576 Committed: https://crrev.com/2142bcde69837585c1571a46cf59715a81d573f9 Cr-Commit-Position: refs/heads/master@{#394638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -52 lines) Patch
M build/config/android/internal_rules.gni View 5 chunks +61 lines, -52 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993893002/1
4 years, 7 months ago (2016-05-18 19:59:26 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 21:11:20 UTC) #4
agrieve
On 2016/05/18 21:11:20, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-19 01:03:09 UTC) #7
Yaron
lgtm
4 years, 7 months ago (2016-05-19 02:04:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993893002/1
4 years, 7 months ago (2016-05-19 02:13:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 02:18:08 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 02:19:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2142bcde69837585c1571a46cf59715a81d573f9
Cr-Commit-Position: refs/heads/master@{#394638}

Powered by Google App Engine
This is Rietveld 408576698