[Findit] Adding script to verify trybot support

[Findit] Adding script to verify trybot support

An example (reduced) report looks like:

Determining missing support...
Master: chromium.memory
OK

Master: chromium.lkgr
Not found. Tryjobs for chromium.lkgr may not be supported.

Master: chromium.win
'WinClang64 (dbg)' is missing.
'Win7 (32) Tests' is missing.
'Win10 Tests x64' is missing.

Master: chromium.chrome
OK

Master: chromium
'Linux' is deprecated

Master: chromium.win
'Win x64 GN' is deprecated
'Win x64 GN (dbg)' is deprecated

Master: chromium.mac
OK

Determining unused variable builders...

Tryserver: tryserver.chromium.mac
'mac_chromium_variable_10.10' is unused.

Tryserver: tryserver.chromium.win
OK


BUG=612926
Committed: https://chromium.googlesource.com/infra/infra/+/1dd4d14d0deec0d99bdd9a6dcfb5d509aa2aee09

[lijeffrey, 2016-05-18 19:37:43]

Description was changed from

==========
[Findit] Adding script to verify trybot support

BUG=
==========

to

==========
[Findit] Adding script to verify trybot support

BUG=612926
==========

[lijeffrey, 2016-05-18 19:37:43]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-05-18 19:40:57]

Description was changed from

==========
[Findit] Adding script to verify trybot support

BUG=612926
==========

to

==========
[Findit] Adding script to verify trybot support

An example (reduced) report looks like:

Determining missing support...
Master: chromium.memory
OK

Master: chromium.lkgr
Not found. Tryjobs for chromium.lkgr may not be supported.

Master: chromium.win
'WinClang64 (dbg)' is missing.
'Win7 (32) Tests' is missing.
'Win10 Tests x64' is missing.

Master: chromium.chrome
OK

Master: chromium
'Linux' is deprecated

Master: chromium.win
'Win x64 GN' is deprecated
'Win x64 GN (dbg)' is deprecated

Master: chromium.mac
OK

Determining unused variable builders...

Tryserver: tryserver.chromium.mac
'mac_chromium_variable_10.10' is unused.

Tryserver: tryserver.chromium.win
OK


BUG=612926
==========

[lijeffrey, 2016-05-18 19:41:24]

ptal

[chanli, 2016-05-18 20:33:57]

https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py
(right):

https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py:88: if
master not in supported_masters:
To improve readability, move 
supported_masters = steps_for_masters_rules.get(
    'supported_masters', {}).keys()

closer?

[stgao, 2016-05-18 20:57:55]

https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py
(right):

https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py:38:
any_missing = False
nit: move to before where it is first used.

[lijeffrey, 2016-05-18 21:13:00]

https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py
(right):

https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py:88: if
master not in supported_masters:
On 2016/05/18 20:33:57, chanli wrote:
> To improve readability, move 
> supported_masters = steps_for_masters_rules.get(
>     'supported_masters', {}).keys()
> 
> closer?

supported_masters is used in line 37 too, moved closer there.

[chanli, 2016-05-18 22:55:20]

On 2016/05/18 21:13:00, lijeffrey wrote:
>
https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
> File appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py
> (right):
> 
>
https://codereview.chromium.org/1993883002/diff/1/appengine/findit/util_scrip...
> appengine/findit/util_scripts/remote_queries/check_trybot_mapping.py:88: if
> master not in supported_masters:
> On 2016/05/18 20:33:57, chanli wrote:
> > To improve readability, move 
> > supported_masters = steps_for_masters_rules.get(
> >     'supported_masters', {}).keys()
> > 
> > closer?
> 
> supported_masters is used in line 37 too, moved closer there.

lgtm

[lijeffrey, 2016-05-18 23:04:35]

The CQ bit was checked by lijeffrey@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:04:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993883002/20001

[stgao, 2016-05-18 23:04:56]

lgtm

[commit-bot: I haz the power, 2016-05-18 23:08:18]

Description was changed from

==========
[Findit] Adding script to verify trybot support

An example (reduced) report looks like:

Determining missing support...
Master: chromium.memory
OK

Master: chromium.lkgr
Not found. Tryjobs for chromium.lkgr may not be supported.

Master: chromium.win
'WinClang64 (dbg)' is missing.
'Win7 (32) Tests' is missing.
'Win10 Tests x64' is missing.

Master: chromium.chrome
OK

Master: chromium
'Linux' is deprecated

Master: chromium.win
'Win x64 GN' is deprecated
'Win x64 GN (dbg)' is deprecated

Master: chromium.mac
OK

Determining unused variable builders...

Tryserver: tryserver.chromium.mac
'mac_chromium_variable_10.10' is unused.

Tryserver: tryserver.chromium.win
OK


BUG=612926
==========

to

==========
[Findit] Adding script to verify trybot support

An example (reduced) report looks like:

Determining missing support...
Master: chromium.memory
OK

Master: chromium.lkgr
Not found. Tryjobs for chromium.lkgr may not be supported.

Master: chromium.win
'WinClang64 (dbg)' is missing.
'Win7 (32) Tests' is missing.
'Win10 Tests x64' is missing.

Master: chromium.chrome
OK

Master: chromium
'Linux' is deprecated

Master: chromium.win
'Win x64 GN' is deprecated
'Win x64 GN (dbg)' is deprecated

Master: chromium.mac
OK

Determining unused variable builders...

Tryserver: tryserver.chromium.mac
'mac_chromium_variable_10.10' is unused.

Tryserver: tryserver.chromium.win
OK


BUG=612926

Committed:
https://chromium.googlesource.com/infra/infra/+/1dd4d14d0deec0d99bdd9a6dcfb5d...
==========

[commit-bot: I haz the power, 2016-05-18 23:08:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/1dd4d14d0deec0d99bdd9a6dcfb5d...