Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java

Issue 1993873003: deprecate notificationId for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java b/content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java
index 7110fe8faec0cbd43a0ae3d3d33a2436b7c02ef6..a3ab93f842213ff807fcb923216af53c27493d2d 100644
--- a/content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java
+++ b/content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java
@@ -18,7 +18,6 @@ public final class DownloadInfo {
private final String mReferer;
private final String mOriginalUrl;
private final long mContentLength;
- private final int mNotificationId;
private final String mDownloadGuid;
private final boolean mHasUserGesture;
private final String mContentDisposition;
@@ -40,7 +39,6 @@ public final class DownloadInfo {
mReferer = builder.mReferer;
mOriginalUrl = builder.mOriginalUrl;
mContentLength = builder.mContentLength;
- mNotificationId = builder.mNotificationId;
mDownloadGuid = builder.mDownloadGuid;
mHasUserGesture = builder.mHasUserGesture;
mIsGETRequest = builder.mIsGETRequest;
@@ -96,10 +94,6 @@ public final class DownloadInfo {
return mIsGETRequest;
}
- public int getNotificationId() {
- return mNotificationId;
- }
-
public String getDownloadGuid() {
return mDownloadGuid;
}
@@ -150,7 +144,6 @@ public final class DownloadInfo {
private String mOriginalUrl;
private long mContentLength;
private boolean mIsGETRequest;
- private int mNotificationId;
private String mDownloadGuid;
private boolean mHasUserGesture;
private String mContentDisposition;
@@ -215,11 +208,6 @@ public final class DownloadInfo {
return this;
}
- public Builder setNotificationId(int notificationId) {
- mNotificationId = notificationId;
- return this;
- }
-
public Builder setDownloadGuid(String downloadGuid) {
mDownloadGuid = downloadGuid;
return this;
@@ -282,7 +270,6 @@ public final class DownloadInfo {
.setReferer(downloadInfo.getReferer())
.setOriginalUrl(downloadInfo.getOriginalUrl())
.setContentLength(downloadInfo.getContentLength())
- .setNotificationId(downloadInfo.getNotificationId())
.setDownloadGuid(downloadInfo.getDownloadGuid())
.setHasUserGesture(downloadInfo.hasUserGesture())
.setContentDisposition(downloadInfo.getContentDisposition())

Powered by Google App Engine
This is Rietveld 408576698