chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java - Issue 1993873003: deprecate notificationId for downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

Issue 1993873003: deprecate notificationId for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java ('k') | content/browser/android/download_controller_android_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

index 3b13768e982352153c243f6d7fbf0abdba6b3d84..d55b36182f30eaecab1e7e70c84b20181d50de41 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

@@ -70,7 +70,7 @@ public class SystemDownloadNotifierTest extends InstrumentationTestCase {

@Feature({"Download"})

public void testNotificationNotHandledUntilServiceConnection() {

DownloadInfo info = new DownloadInfo.Builder()

- .setDownloadGuid(UUID.randomUUID().toString()).setNotificationId(1).build();

+ .setDownloadGuid(UUID.randomUUID().toString()).build();

mDownloadNotifier.notifyDownloadProgress(info, 1L, true);

assertTrue(mDownloadNotifier.mStarted);

@@ -87,16 +87,16 @@ public class SystemDownloadNotifierTest extends InstrumentationTestCase {

public void testServiceStoppedWhenAllDownloadsFinish() {

onServiceConnected();

DownloadInfo info = new DownloadInfo.Builder()

- .setDownloadGuid(UUID.randomUUID().toString()).setNotificationId(1).build();

+ .setDownloadGuid(UUID.randomUUID().toString()).build();

mDownloadNotifier.notifyDownloadProgress(info, 1L, true);

assertTrue(mDownloadNotifier.mStarted);

DownloadInfo info2 = new DownloadInfo.Builder()

- .setDownloadGuid(UUID.randomUUID().toString()).setNotificationId(2).build();

+ .setDownloadGuid(UUID.randomUUID().toString()).build();

mDownloadNotifier.notifyDownloadProgress(info2, 1L, true);

mDownloadNotifier.notifyDownloadFailed(info);

assertTrue(mDownloadNotifier.mStarted);

- mDownloadNotifier.notifyDownloadSuccessful(info2, null);

+ mDownloadNotifier.notifyDownloadSuccessful(info2, 100L, true, null);

assertFalse(mDownloadNotifier.mStarted);

}