chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java - Issue 1993873003: deprecate notificationId for downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

Issue 1993873003: deprecate notificationId for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

index 7988351e16200679df43a63897e8939bc4622a5c..7c09d2deb76e683a53bb12ac97ee30e989abb8b1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

@@ -39,16 +39,6 @@ public class DownloadItem {

}

/**

- * @return notification ID for this download.

- */

- public int getNotificationId() {

- if (mUseAndroidDownloadManager) {

- return (int) mDownloadId;

- }

- return mDownloadInfo.getNotificationId();

- }

- /**

* @return System download ID from the Android DownloadManager.

public long getSystemDownloadId() {