Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1993863002: DEPS bump to grab linter `0.1.17`. (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
Reviewers:
scheglov, keertip
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DEPS bump to grab linter `0.1.17`. Adds: * Fix to `public_member_api_docs` to check for documented getters when checking setters (#237). * New `iterable_contains_unrelated_type` lint to detect when `Iterable.contains` is invoked with an object of an unrelated type. * New `comment_references` lint to ensure identifiers referenced in docs are in scope (#240). BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d0d1a918cb7fc1d50014121091ce7438e89949a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-18 18:36:56 UTC) #2
scheglov
lgtm
4 years, 7 months ago (2016-05-18 19:08:57 UTC) #3
pquitslund
4 years, 7 months ago (2016-05-18 19:10:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0d1a918cb7fc1d50014121091ce7438e89949a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698