Use LocalStyleChange for classes in rightmost compound selector.

Use LocalStyleChange for classes in rightmost compound selector.

If we resort to not using invalidation sets, we can still use
LocalStyleChange instead of SubtreeStyleChange for classes in the rightmost
compound selector if the invalidation set approach was not dropped due to a
feature in the rightmost compound selector. For classes in other compound
selectors, still use SubtreeStyleChange.

Examples:

".a + .b" -> LocalStyleChange for "b", SubtreeStyleChange for "a"
".a .b::first-letter" -> SubtreeStyleChange for both "a" and "b".

R=esprehn@chromium.org,chrishtr@chromium.org
BUG=335247
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169255

[esprehn, 2014-03-13 23:28:13]

lgtm, but the naming is kind of weird.

https://codereview.chromium.org/199373003/diff/1/Source/core/css/RuleFeature.cpp
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/199373003/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:227: } else if (current->m_match ==
CSSSelector::Class && mode != UseInvalidationSets) {
This is confusing since you're saying "mode is not UseInvalidationSets" and then
you're creating an invalidation set right below.

[rune, 2014-03-14 13:01:19]

https://codereview.chromium.org/199373003/diff/1/Source/core/css/RuleFeature.cpp
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/199373003/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:227: } else if (current->m_match ==
CSSSelector::Class && mode != UseInvalidationSets) {
On 2014/03/13 23:28:13, esprehn wrote:
> This is confusing since you're saying "mode is not UseInvalidationSets" and
then
> you're creating an invalidation set right below.

Renamed now.

[rune, 2014-03-14 13:01:27]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-03-14 13:01:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/199373003/20001

[commit-bot: I haz the power, 2014-03-14 13:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 13:45:39]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[rune, 2014-03-14 13:55:09]

The CQ bit was checked by rune@opera.com

[rune, 2014-03-14 13:55:10]

The CQ bit was unchecked by rune@opera.com

[rune, 2014-03-14 13:55:11]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-03-14 13:55:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/199373003/20001

[commit-bot: I haz the power, 2014-03-14 14:38:50]

Change committed as 169255