third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1993713002: Move line painting to BlockFlowPainter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1993713002: Move line painting to BlockFlowPainter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 483b1a38a4c12101b60576d971fcba799bdb1dc8..3b054cf247b504755b7f2175bdbaf0827f8bfffe 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -302,9 +302,7 @@ protected:

public:

virtual void paintObject(const PaintInfo&, const LayoutPoint&) const;

virtual void paintChildren(const PaintInfo&, const LayoutPoint&) const;

- // FIXME-BLOCKFLOW: Remove virtualization when all callers have moved to LayoutBlockFlow

- virtual void paintFloats(const PaintInfo&, const LayoutPoint&) const { }

+ virtual void paintContentsAndFloats(const PaintInfo&, const LayoutPoint&) const;

protected:

virtual void adjustInlineDirectionLineBounds(unsigned /* expansionOpportunityCount */, LayoutUnit& /* logicalLeft */, LayoutUnit& /* logicalWidth */) const { }

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/paint/BlockPainter.cpp » ('J')