Issue 1993673002: Don't iterate over IC data that may be updated by the mutator thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1993673002: Don't iterate over IC data that may be updated by the mutator thread. (Closed)

Created:
4 years, 7 months ago by Florian Schneider

Modified:
4 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't iterate over IC data that may be updated by the mutator thread. We can't iterate over the original IC data (like NumberOfUsedChecks does) since the mutator thread may grow the IC data array concurrently. This works around this issue by using the cloned IC data. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/9c44eadd224ce2aa86f39f5f3613cc9e926ae632

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 7 months ago (2016-05-18 11:07:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9c44eadd224ce2aa86f39f5f3613cc9e926ae632 (presubmit successful).