Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/instance_ref.html

Issue 199363002: Rework library and class view pages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
diff --git a/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html b/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
index e03e1d28477497cb6e2ea297805338355f1e110c..4fae42636f331bc7d665108e5451d4411f456384 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
@@ -6,9 +6,17 @@
<polymer-element name="instance-ref" extends="service-ref">
<template>
<style>
- .member {
+ .memberList {
+ display: table;
+ }
+ .memberItem {
+ display: table-row;
+ }
+ .memberName, .memberValue {
+ display: table-cell;
vertical-align: top;
- padding: 1px 0 1px 1em;
+ padding: 3px 0 3px 1em;
+ font: 400 14px 'Montserrat', sans-serif;
}
</style>
<div>
@@ -32,6 +40,7 @@
<template if="{{ isClosure(ref.serviceType) }}">
<a href="{{ url }}">
+ <!-- TODO(turnidge): Switch this to fully-qualified function -->
{{ ref['closureFunc']['user_name'] }}
</a>
</template>
@@ -39,28 +48,34 @@
<template if="{{ isInstance(ref.serviceType) }}">
<a href="{{ url }}"><em>{{ ref['class']['user_name'] }}</em></a>
<curly-block callback="{{ expander() }}">
- <table>
- <tr template repeat="{{ field in ref['fields'] }}">
- <td class="member">{{ field['decl']['user_name'] }}</td>
- <td class="member">
- <instance-ref ref="{{ field['value'] }}"></instance-ref>
- </td>
- </tr>
- </table>
+ <div class="memberList">
+ <template repeat="{{ field in ref['fields'] }}">
+ <div class="memberItem">
+ <div class="memberName">
+ {{ field['decl']['user_name'] }}
+ </div>
+ <div class="memberValue">
+ <instance-ref ref="{{ field['value'] }}"></instance-ref>
+ </div>
+ </div>
+ </template>
+ </div>
</curly-block>
</template>
<template if="{{ isList(ref.serviceType) }}">
<a href="{{ url }}"><em>{{ ref['class']['user_name'] }}</em> ({{ ref['length']}})</a>
<curly-block callback="{{ expander() }}">
- <table>
- <tr template repeat="{{ element in ref['elements'] }}">
- <td class="member">[{{ element['index']}}]</td>
- <td class="member">
- <instance-ref ref="{{ element['value'] }}"></instance-ref>
- </td>
- </tr>
- </table>
+ <div class="memberList">
+ <template repeat="{{ element in ref['elements'] }}">
+ <div class="memberItem">
+ <div class="memberName">[{{ element['index']}}]</div>
+ <div class="memberValue">
+ <instance-ref ref="{{ element['value'] }}"></instance-ref>
+ </div>
+ </div>
+ </template>
+ </div>
</curly-block>
</template>

Powered by Google App Engine
This is Rietveld 408576698