Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 199363002: Rework library and class view pages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: edits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart
index 6d14e12e37db615417a6e8b3eaf8d2e0994c742a..4c32d58d4bf3ea845aeb8a33f94889e173359948 100644
--- a/runtime/bin/vmservice/client/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart
@@ -58,6 +58,12 @@ class Isolate extends ServiceObject {
_codes._updateProfileData(profile, codeTable);
}
+ Future<ServiceObject> getDirect(String serviceId) {
+ return vm.getAsMap(relativeLink(serviceId)).then((ObservableMap m) {
+ return _upgradeToServiceObject(vm, this, m);
+ });
+ }
+
/// Requests [serviceId] from [this]. Completes to a [ServiceObject].
/// Can return pre-existing, cached, [ServiceObject]s.
Future<ServiceObject> get(String serviceId) {
@@ -70,9 +76,7 @@ class Isolate extends ServiceObject {
if (_classes.cachesId(serviceId)) {
return _classes.get(serviceId);
}
- return vm.getAsMap(relativeLink(serviceId)).then((ObservableMap m) {
- return _upgradeToServiceObject(vm, this, m);
- });
+ return getDirect(serviceId);
}
@observable ServiceMap rootLib;

Powered by Google App Engine
This is Rietveld 408576698