Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993623002: Move adjustAmountOfExternalMemory after allocation call (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move adjustAmountOfExternalMemory after allocation call BUG=chromium:611688 LOG=N Committed: https://crrev.com/34689ee3d1d8f80d2ea34fadccb2b3e6f422d3a2 Cr-Commit-Position: refs/heads/master@{#394374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Lippautz
Addressing comment from https://codereview.chromium.org/1977493003/
4 years, 7 months ago (2016-05-18 08:06:28 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-18 08:07:29 UTC) #3
sof
lgtm
4 years, 7 months ago (2016-05-18 08:37:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993623002/1
4 years, 7 months ago (2016-05-18 08:48:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 09:59:27 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 10:01:16 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/34689ee3d1d8f80d2ea34fadccb2b3e6f422d3a2
Cr-Commit-Position: refs/heads/master@{#394374}

Powered by Google App Engine
This is Rietveld 408576698