Add a field study to use new reload behavior even on desktops

Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/8a956ecdb3d8794d1ddb0a4003e818bfbd19ebef
Cr-Commit-Position: refs/heads/master@{#394706}

[Takashi Toyoshima, 2016-05-18 09:08:14]

Description was changed from

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
==========

to

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-05-18 09:10:44]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 09:10:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993603003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993603003/1

[Takashi Toyoshima, 2016-05-18 09:10:59]

Description was changed from

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-05-18 09:10:59]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[commit-bot: I haz the power, 2016-05-18 09:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 09:22:49]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Takashi Toyoshima, 2016-05-19 01:52:36]

Kinuko, can you take a look?

[kinuko, 2016-05-19 02:20:35]

https://codereview.chromium.org/1993603003/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1993603003/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:998: kOsAndroid | kOsMac | kOsWin | kOsLinux |
kOsCrOS,
kOsAll ?

https://codereview.chromium.org/1993603003/diff/20001/content/browser/loader/...
File content/browser/loader/reload_cache_control_browsertest.cc (right):

https://codereview.chromium.org/1993603003/diff/20001/content/browser/loader/...
content/browser/loader/reload_cache_control_browsertest.cc:79: void SetUp()
override {
SetUpOnMainThread?

(From a quick code reading BrowserTestBase::SetUp seems to be calling
ClearInstanceForTesting, having this here still works though?)

[Takashi Toyoshima, 2016-05-19 03:56:37]

https://codereview.chromium.org/1993603003/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1993603003/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:998: kOsAndroid | kOsMac | kOsWin | kOsLinux |
kOsCrOS,
Ah, thanks. I misunderstood that kOsAll includes iOS, but it doesn't.

https://codereview.chromium.org/1993603003/diff/20001/content/browser/loader/...
File content/browser/loader/reload_cache_control_browsertest.cc (right):

https://codereview.chromium.org/1993603003/diff/20001/content/browser/loader/...
content/browser/loader/reload_cache_control_browsertest.cc:79: void SetUp()
override {
On 2016/05/19 02:20:34, kinuko wrote:
> SetUpOnMainThread?
> 
> (From a quick code reading BrowserTestBase::SetUp seems to be calling
> ClearInstanceForTesting, having this here still works though?)

Done.

[kinuko, 2016-05-19 05:14:13]

lgtm.

[Takashi Toyoshima, 2016-05-19 05:38:09]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-05-19 05:38:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993603003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993603003/40001

[commit-bot: I haz the power, 2016-05-19 07:24:48]

Description was changed from

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-05-19 07:24:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-19 07:25:55]

Description was changed from

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a field study to use new reload behavior even on desktops

Now the new reload is used in a field study for Android pull-to-refresh,
but this change introduces it even on desktops as it replaces the
traditional reload operations.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/8a956ecdb3d8794d1ddb0a4003e818bfbd19ebef
Cr-Commit-Position: refs/heads/master@{#394706}
==========

[commit-bot: I haz the power, 2016-05-19 07:25:56]

Patchset 3 (id:??) landed as
https://crrev.com/8a956ecdb3d8794d1ddb0a4003e818bfbd19ebef
Cr-Commit-Position: refs/heads/master@{#394706}