Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 1993593003: binding: Check the type of property names in FooCallback instead of Foo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
index 2f00995cc958488967692dc9541c68399c672791..aca14c68a795abae8e5d9c52d4dbe14fbc409e08 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
@@ -1875,8 +1875,6 @@ static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCal
static void namedPropertyGetter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- if (!name->IsString())
- return;
auto nameString = name.As<v8::String>();
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
AtomicString propertyName = toCoreAtomicString(nameString);
@@ -1888,13 +1886,13 @@ static void namedPropertyGetter(v8::Local<v8::Name> name, const v8::PropertyCall
static void namedPropertyGetterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
+ if (!name->IsString())
+ return;
TestInterfaceImplementationV8Internal::namedPropertyGetter(name, info);
}
static void namedPropertySetter(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- if (!name->IsString())
- return;
auto nameString = name.As<v8::String>();
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
V8StringResource<> propertyName(nameString);
@@ -1911,13 +1909,13 @@ static void namedPropertySetter(v8::Local<v8::Name> name, v8::Local<v8::Value> v
static void namedPropertySetterCallback(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
{
+ if (!name->IsString())
+ return;
TestInterfaceImplementationV8Internal::namedPropertySetter(name, v8Value, info);
}
static void namedPropertyQuery(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- if (!name->IsString())
- return;
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
AtomicString propertyName = toCoreAtomicString(name.As<v8::String>());
v8::String::Utf8Value namedProperty(name);
@@ -1932,13 +1930,13 @@ static void namedPropertyQuery(v8::Local<v8::Name> name, const v8::PropertyCallb
static void namedPropertyQueryCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
+ if (!name->IsString())
+ return;
TestInterfaceImplementationV8Internal::namedPropertyQuery(name, info);
}
static void namedPropertyDeleter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- if (!name->IsString())
- return;
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
AtomicString propertyName = toCoreAtomicString(name.As<v8::String>());
DeleteResult result = impl->anonymousNamedDeleter(propertyName);
@@ -1948,6 +1946,8 @@ static void namedPropertyDeleter(v8::Local<v8::Name> name, const v8::PropertyCal
static void namedPropertyDeleterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
+ if (!name->IsString())
+ return;
TestInterfaceImplementationV8Internal::namedPropertyDeleter(name, info);
}

Powered by Google App Engine
This is Rietveld 408576698