Show notification instead of opening app launcher after extension installation

chrome/browser/ui/extensions/extension_installed_notification.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_NOTIFICATION_H_
+#define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_NOTIFICATION_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/notifications/notification_delegate.h"
+#include "chrome/browser/profiles/profile.h"
+#include "extensions/common/extension.h"
+
+class ExtensionInstalledNotification : public NotificationDelegate {
+ public:
+  static void Show(const extensions::Extension* extension, Profile* profile);
+
+  ExtensionInstalledNotification(const extensions::Extension* extension,
+                                 Profile* profile);
+
+  // NotificationDelegate override:
+  void Click() override;
+  std::string id() const override;
+
+ protected:
+  // This class is ref-counted.
+  ~ExtensionInstalledNotification() override;
+
+ private:
+  scoped_refptr<const extensions::Extension> extension_;

[benwells, 2016/05/20 00:17:29]

I think holding on to a refptr to extension is a bad idea. While it is ref
counted, most things don't use it that way.

A safer approach is to grab the data you need off the extension pointer in
construction (maybe just id) and then look up the information later.

[yoshiki, 2016/05/24 16:25:18]

Thank you for guidance. Done.

+  Profile* profile_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionInstalledNotification);
+};
+
+#endif  // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_NOTIFICATION_H_