Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993543002: cc: Move cc param traits tests to cc/ipc (Closed)

Created:
4 years, 7 months ago by Fady Samuel
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move cc param traits tests to cc/ipc BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f76098e640d89bd1fce6511b901f495138f70094 Cr-Commit-Position: refs/heads/master@{#394459}

Patch Set 1 #

Patch Set 2 : Removed cc_messages_perftest from build #

Patch Set 3 : Fix typo #

Patch Set 4 : Added IPC dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -969 lines) Patch
M cc/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 5 chunks +6 lines, -0 lines 0 comments Download
A + cc/ipc/cc_param_traits_perftest.cc View 6 chunks +8 lines, -13 lines 0 comments Download
A + cc/ipc/cc_param_traits_unittest.cc View 18 chunks +53 lines, -107 lines 0 comments Download
M content/common/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/common/cc_messages_perftest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D content/common/cc_messages_unittest.cc View 1 chunk +0 lines, -682 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 30 (14 generated)
Fady Samuel
4 years, 7 months ago (2016-05-18 01:33:26 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993543002/1
4 years, 7 months ago (2016-05-18 01:34:38 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/189452) win8_chromium_ng on ...
4 years, 7 months ago (2016-05-18 01:39:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993543002/20001
4 years, 7 months ago (2016-05-18 01:50:28 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993543002/40001
4 years, 7 months ago (2016-05-18 02:10:44 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/205346)
4 years, 7 months ago (2016-05-18 02:44:24 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993543002/60001
4 years, 7 months ago (2016-05-18 14:29:29 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 15:37:18 UTC) #17
piman
lgtm
4 years, 7 months ago (2016-05-18 16:56:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993543002/60001
4 years, 7 months ago (2016-05-18 16:57:41 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/185521)
4 years, 7 months ago (2016-05-18 17:05:29 UTC) #22
Fady Samuel
+tsepez@ for IPC move.
4 years, 7 months ago (2016-05-18 17:16:12 UTC) #24
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-18 17:21:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993543002/60001
4 years, 7 months ago (2016-05-18 17:22:37 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-18 17:27:03 UTC) #28
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 17:28:26 UTC) #30
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f76098e640d89bd1fce6511b901f495138f70094
Cr-Commit-Position: refs/heads/master@{#394459}

Powered by Google App Engine
This is Rietveld 408576698