MD User Manager: Clear existing error messages before browser calls

chrome/browser/resources/md_user_manager/create_profile.js

Index: chrome/browser/resources/md_user_manager/create_profile.js
diff --git a/chrome/browser/resources/md_user_manager/create_profile.js b/chrome/browser/resources/md_user_manager/create_profile.js
index 390954baa2c99903a122caf21ed8c9b113cc62aa..8df2dd9d1c15097aa8f8a044cbd1bc18d0aea99c 100644
--- a/chrome/browser/resources/md_user_manager/create_profile.js
+++ b/chrome/browser/resources/md_user_manager/create_profile.js
@@ -214,6 +214,8 @@ Polymer({
       this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
     } else {
       var signedInUser = this.signedInUser_(this.signedInUserIndex_);
+      // Clear any existing error messages.
+      this.handleMessage_('');

[Dan Beam, 2016/05/19 20:30:44]

this is fine, but if you feel the need to add a comment at every call site,
maybe just added a:

  clearMessage_: function() {
    this.handleMessage_();
  },

so from each callsite you have:

  this.clearMessage_();

rather than

  // Clear any existing error messages.
  this.handleMessage_('');

[Dan Beam, 2016/05/19 22:28:32]

sorry, this should be handleMessage_('')
                                     ^^

[Moe, 2016/05/20 13:49:27]

Makes sense. Done.

[Moe, 2016/05/20 13:49:27]

Ended up setting the message to '' directly in clearMessage_(). handleMessage_()
sets this.createInProgress_ to false. It didn't make sense to set it to false
and then right back to true in the next line.

       this.createInProgress_ = true;
       this.browserProxy_.getExistingSupervisedUsers(signedInUser.profilePath)
           .then(this.showImportSupervisedUserPopup_.bind(this),
@@ -235,6 +237,8 @@ Polymer({
       this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
     } else {
       var signedInUser = this.signedInUser_(this.signedInUserIndex_);
+      // Clear any existing error messages.
+      this.handleMessage_('');
       this.createInProgress_ = true;
       this.browserProxy_.getExistingSupervisedUsers(signedInUser.profilePath)
           .then(this.createProfileIfValidSupervisedUser_.bind(this),
@@ -321,6 +325,8 @@ Polymer({
       custodianProfilePath =
           this.signedInUser_(this.signedInUserIndex_).profilePath;
     }
+    // Clear any existing error messages.
+    this.handleMessage_('');
     this.createInProgress_ = true;
     this.browserProxy_.createProfile(
         this.profileName_, this.profileIconUrl_, this.isSupervised_, '',
@@ -337,6 +343,8 @@ Polymer({
   onImportUserPopupImport_: function(event) {
     var supervisedUser = event.detail.supervisedUser;
     var signedInUser = event.detail.signedInUser;
+    // Clear any existing error messages.
+    this.handleMessage_('');
     this.createInProgress_ = true;
     this.browserProxy_.createProfile(
         supervisedUser.name, supervisedUser.iconURL, true, supervisedUser.id,