MD User Manager: Clear existing error messages before browser calls

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 (function() {
 /**
@@ skipping 196 matching lines @@
    * Handler for the 'Import Supervised User' link tap event.
    * @param {!Event} event
    * @private
    */
   onImportUserTap_: function(event) {
     if (this.signedInUserIndex_ == NO_USER_SELECTED) {
       // A custodian must be selected.
       this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
     } else {
       var signedInUser = this.signedInUser_(this.signedInUserIndex_);
+      // Clear any existing error messages.
+      this.handleMessage_('');

[Dan Beam, 2016/05/19 20:30:44]

this is fine, but if you feel the need to add a comment at every call site,
maybe just added a:

  clearMessage_: function() {
    this.handleMessage_();
  },

so from each callsite you have:

  this.clearMessage_();

rather than

  // Clear any existing error messages.
  this.handleMessage_('');

[Dan Beam, 2016/05/19 22:28:32]

sorry, this should be handleMessage_('')
                                     ^^

[Moe, 2016/05/20 13:49:27]

Makes sense. Done.

[Moe, 2016/05/20 13:49:27]

Ended up setting the message to '' directly in clearMessage_(). handleMessage_()
sets this.createInProgress_ to false. It didn't make sense to set it to false
and then right back to true in the next line.

       this.createInProgress_ = true;
       this.browserProxy_.getExistingSupervisedUsers(signedInUser.profilePath)
           .then(this.showImportSupervisedUserPopup_.bind(this),
                 this.handleMessage_.bind(this));
     }
   },
 
   /**
    * Handler for the 'Save' button tap event.
    * @param {!Event} event
    * @private
    */
   onSaveTap_: function(event) {
     if (!this.isSupervised_) {
       // The new profile is not supervised. Go ahead and create it.
       this.createProfile_();
     } else if (this.signedInUserIndex_ == NO_USER_SELECTED) {
       // If the new profile is supervised, a custodian must be selected.
       this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
     } else {
       var signedInUser = this.signedInUser_(this.signedInUserIndex_);
+      // Clear any existing error messages.
+      this.handleMessage_('');
       this.createInProgress_ = true;
       this.browserProxy_.getExistingSupervisedUsers(signedInUser.profilePath)
           .then(this.createProfileIfValidSupervisedUser_.bind(this),
                 this.handleMessage_.bind(this));
     }
   },
 
   /**
    * Displays the import supervised user popup.
    * @param {!Array<!SupervisedUser>} supervisedUsers The list of existing
@@ skipping 66 matching lines @@
   /**
    * Creates the new profile.
    * @private
    */
   createProfile_: function() {
     var custodianProfilePath = '';
     if (this.signedInUserIndex_ != NO_USER_SELECTED) {
       custodianProfilePath =
           this.signedInUser_(this.signedInUserIndex_).profilePath;
     }
+    // Clear any existing error messages.
+    this.handleMessage_('');
     this.createInProgress_ = true;
     this.browserProxy_.createProfile(
         this.profileName_, this.profileIconUrl_, this.isSupervised_, '',
         custodianProfilePath);
   },
 
   /**
    * Handler for the 'import' event fired by #importUserPopup once a supervised
    * user is selected to be imported and the popup closes.
    * @param {!{detail: {supervisedUser: !SupervisedUser,
    *                    signedInUser: !SignedInUser}}} event
    * @private
    */
   onImportUserPopupImport_: function(event) {
     var supervisedUser = event.detail.supervisedUser;
     var signedInUser = event.detail.signedInUser;
+    // Clear any existing error messages.
+    this.handleMessage_('');
     this.createInProgress_ = true;
     this.browserProxy_.createProfile(
         supervisedUser.name, supervisedUser.iconURL, true, supervisedUser.id,
         signedInUser.profilePath);
   },
 
   /**
    * Handler for the 'Cancel' button tap event.
    * @param {!Event} event
    * @private
@@ skipping 34 matching lines @@
     this.createInProgress_ = false;
     if (profileInfo.showConfirmation) {
       this.fire('change-page', {page: 'supervised-create-confirm-page',
                                 data: profileInfo});
     } else {
       this.fire('change-page', {page: 'user-pods-page'});
     }
   },
 
   /**
    * Handles profile create/import warning/error message pushed by the browser.

[Dan Beam, 2016/05/19 20:30:44]

this says "pushed by the browser" which is a little less true now

    * @param {*} message An HTML warning/error message.
    * @private
    */
   handleMessage_: function(message) {
     this.createInProgress_ = false;
     this.message_ = '' + message;
   },
 
   /**
    * Returns a translated message that contains link elements with the 'id'
@@ skipping 54 matching lines @@
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());