Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1993503004:
MD User Manager: Clear existing error messages before browser calls (Closed)
|
Created:
4 years, 7 months ago by Moe Modified:
4 years, 7 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD User Manager: Clear existing error messages before browser calls.
BUG=563722, 609764
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/b1e59acc1b38d2d1eed4ad4e4196e2000810082c
Cr-Commit-Position: refs/heads/master@{#395071}
Patch Set 1 #
Total comments: 5
Patch Set 2 : Addressed comments #Messages
Total messages: 15 (7 generated)
Description was changed from ========== Clean existing error messages before attempting to create a profile. BUG=563722, 609764 ========== to ========== Clean existing error messages before attempting to create a profile. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Clean existing error messages before attempting to create a profile. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD User Manager: Clear existing error messages before browser calls. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
mahmadi@chromium.org changed reviewers: + dbeam@chromium.org
Hi Dan, Please review this CL.
lgtm https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/create_profile.js (right): https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.js:218: this.handleMessage_(''); this is fine, but if you feel the need to add a comment at every call site, maybe just added a: clearMessage_: function() { this.handleMessage_(); }, so from each callsite you have: this.clearMessage_(); rather than // Clear any existing error messages. this.handleMessage_(''); https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.js:402: * Handles profile create/import warning/error message pushed by the browser. this says "pushed by the browser" which is a little less true now
https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/create_profile.js (right): https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.js:218: this.handleMessage_(''); On 2016/05/19 20:30:44, Dan Beam wrote: > this is fine, but if you feel the need to add a comment at every call site, > maybe just added a: > > clearMessage_: function() { > this.handleMessage_(); sorry, this should be handleMessage_('') ^^ > }, > > so from each callsite you have: > > this.clearMessage_(); > > rather than > > // Clear any existing error messages. > this.handleMessage_('');
Thanks Dan! https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/create_profile.js (right): https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.js:218: this.handleMessage_(''); On 2016/05/19 22:28:32, Dan Beam wrote: > On 2016/05/19 20:30:44, Dan Beam wrote: > > this is fine, but if you feel the need to add a comment at every call site, > > maybe just added a: > > > > clearMessage_: function() { > > this.handleMessage_(); > > sorry, this should be handleMessage_('') > ^^ > > }, > > > > so from each callsite you have: > > > > this.clearMessage_(); > > > > rather than > > > > // Clear any existing error messages. > > this.handleMessage_(''); Ended up setting the message to '' directly in clearMessage_(). handleMessage_() sets this.createInProgress_ to false. It didn't make sense to set it to false and then right back to true in the next line. https://codereview.chromium.org/1993503004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.js:218: this.handleMessage_(''); On 2016/05/19 20:30:44, Dan Beam wrote: > this is fine, but if you feel the need to add a comment at every call site, > maybe just added a: > > clearMessage_: function() { > this.handleMessage_(); > }, > > so from each callsite you have: > > this.clearMessage_(); > > rather than > > // Clear any existing error messages. > this.handleMessage_(''); Makes sense. Done.
Thanks Dan!
The CQ bit was checked by mahmadi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/1993503004/#ps20001 (title: "Addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993503004/20001
Message was sent while issue was closed.
Description was changed from ========== MD User Manager: Clear existing error messages before browser calls. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD User Manager: Clear existing error messages before browser calls. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MD User Manager: Clear existing error messages before browser calls. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD User Manager: Clear existing error messages before browser calls. BUG=563722, 609764 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b1e59acc1b38d2d1eed4ad4e4196e2000810082c Cr-Commit-Position: refs/heads/master@{#395071} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b1e59acc1b38d2d1eed4ad4e4196e2000810082c Cr-Commit-Position: refs/heads/master@{#395071} |
