Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 19934006: Simplified large object allocation strategy. (Closed)

Created:
7 years, 5 months ago by Hannes Payer (out of office)
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Simplified large object allocation strategy. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15840

Patch Set 1 #

Total comments: 16

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -59 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/heap.cc View 1 5 chunks +16 lines, -46 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-22 14:50:24 UTC) #1
Michael Starzinger
LGTM (with comments). Mostly style nits. Just one real comment about the assertion in MacroAssembler::Allocate. ...
7 years, 5 months ago (2013-07-22 19:27:44 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/19934006/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/19934006/diff/1/src/heap.cc#newcode5356 src/heap.cc:5356: On 2013/07/22 19:27:50, Michael Starzinger wrote: > nit: Let's ...
7 years, 5 months ago (2013-07-23 20:00:51 UTC) #3
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-23 20:01:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698