Adding Event.Latency.Browser.WheelUI, Passing latency_info to ProcessMouse/MouseWheelEvent functions

Adding Event.Latency.Browser.WheelUI, Passing latency_info to ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry latency info for mouse/mouseWheel events. The latency_info was needed for the Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes and/or overridden functions.

BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d9c26df2531fb850b0f6523b3f55345a74a7ed51
Cr-Commit-Position: refs/heads/master@{#398302}

[sahel, 2016-05-19 21:35:51]

Description was changed from

==========
Adding  Event.Latency.Browser.WheelUI for Aura.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
==========

to

==========
Adding  Event.Latency.Browser.WheelUI for Aura.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[sahel, 2016-05-19 22:07:25]

Patchset #1 (id:1) has been deleted

[sahel, 2016-05-19 22:09:45]

Description was changed from

==========
Adding  Event.Latency.Browser.WheelUI for Aura.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Adding  Event.Latency.Browser.WheelUI for Aura.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[sahel, 2016-05-19 22:09:45]

sahel@chromium.org changed reviewers:
+ tdresser@chromium.org

[sahel, 2016-05-20 17:09:22]

I left the comments as they are,
We need to replace them with a proper note/Todo or completely remove them.

[tdresser, 2016-05-20 17:24:54]

Update TEST= line to "EventTest.MouseEventLatencyUIComponentExists,
EventTest.MouseEventLatencyUIComponentExists"

https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/cross_process_frame_connector.cc (right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_h...
content/browser/frame_host/cross_process_frame_connector.cc:177: //I can change
function signiture and pass latency to it.
Add a TODO and link to the bug you filed.

Same thing with the cases below.

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:145:
ui::LatencyInfo latency_info;
Same as before - use a TODO with a link to the bug you filed, and same below.

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:1999: 0, 0);
Why this change? The change description states that the functional change is
Aura only, but this is a Mac change. This also appears untested.

[sahel, 2016-05-20 17:35:22]

Description was changed from

==========
Adding  Event.Latency.Browser.WheelUI for Aura.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Adding  Event.Latency.Browser.WheelUI.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[sahel, 2016-05-20 18:07:28]

Description was changed from

==========
Adding  Event.Latency.Browser.WheelUI.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[sahel, 2016-05-20 18:10:44]

Description was changed from

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions.
Many files are modified due to propagation of these function signiture
changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry
latency info for mouse/mouseWheel events. The latency_info was needed for the
Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes
and/or overridden functions.

BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[sahel, 2016-05-20 18:38:20]

https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/cross_process_frame_connector.cc (right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_h...
content/browser/frame_host/cross_process_frame_connector.cc:177: //I can change
function signiture and pass latency to it.
On 2016/05/20 17:24:53, tdresser wrote:
> Add a TODO and link to the bug you filed.
> 
> Same thing with the cases below.

Done.

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:145:
ui::LatencyInfo latency_info;
On 2016/05/20 17:24:54, tdresser wrote:
> Same as before - use a TODO with a link to the bug you filed, and same below.

Done.

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:1999: 0, 0);
On 2016/05/20 17:24:54, tdresser wrote:
> Why this change? The change description states that the functional change is
> Aura only, but this is a Mac change. This also appears untested.

Adding WheelUI was only for mac but I explained that many files were changed due
to change of two function signatures.This is true for here as well, I used to
add latency_info within ProcessMouseheelEvent for mac, but now, I add it before
calling the function and pass it as an argument. The test that I wrote before
for chaecking the exsitance of input latency info is still valid.

[tdresser, 2016-05-20 18:45:53]

LGTM with formatting nits.

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/1993383002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:1999: 0, 0);
On 2016/05/20 18:38:20, sahel wrote:
> On 2016/05/20 17:24:54, tdresser wrote:
> > Why this change? The change description states that the functional change is
> > Aura only, but this is a Mac change. This also appears untested.
> 
> Adding WheelUI was only for mac but I explained that many files were changed
due
> to change of two function signatures.This is true for here as well, I used to
> add latency_info within ProcessMouseheelEvent for mac, but now, I add it
before
> calling the function and pass it as an argument. The test that I wrote before
> for chaecking the exsitance of input latency info is still valid.

Oops, of course, thanks.

https://codereview.chromium.org/1993383002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/cross_process_frame_connector.cc (right):

https://codereview.chromium.org/1993383002/diff/40001/content/browser/frame_h...
content/browser/frame_host/cross_process_frame_connector.cc:175: // TODO:
https://bugs.chromium.org/p/chromium/issues/detail?id=613628
And reformat TODOs here.

https://codereview.chromium.org/1993383002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/1993383002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:145: //
TODO: https://bugs.chromium.org/p/chromium/issues/detail?id=613628
Nit:
Format these TODOs this way

TODO(crbug.com/613628): Initialize latency info correctly for OOPIFs.

[sahel, 2016-05-20 19:03:27]

sahel@chromium.org changed reviewers:
+ jam@chromium.org

[sahel, 2016-05-20 19:03:28]

jam@chromium.org: Please review changes in

https://codereview.chromium.org/1993383002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/cross_process_frame_connector.cc (right):

https://codereview.chromium.org/1993383002/diff/40001/content/browser/frame_h...
content/browser/frame_host/cross_process_frame_connector.cc:175: // TODO:
https://bugs.chromium.org/p/chromium/issues/detail?id=613628
On 2016/05/20 18:45:53, tdresser wrote:
> And reformat TODOs here.

Done.

https://codereview.chromium.org/1993383002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/1993383002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:145: //
TODO: https://bugs.chromium.org/p/chromium/issues/detail?id=613628
On 2016/05/20 18:45:53, tdresser wrote:
> Nit:
> Format these TODOs this way
> 
> TODO(crbug.com/613628): Initialize latency info correctly for OOPIFs.

Done.

[sahel, 2016-05-24 19:15:51]

sahel@chromium.org changed reviewers:
- jam@chromium.org

[sahel, 2016-05-24 19:20:53]

sahel@chromium.org changed reviewers:
+ cpu@chromium.org

[sahel, 2016-05-24 19:20:54]

cpu@chromium.org: Please review changes in

[sahel, 2016-05-27 15:50:40]

sahel@chromium.org changed reviewers:
- cpu@chromium.org

[sahel, 2016-05-27 15:51:13]

sahel@chromium.org changed reviewers:
+ piman@chromium.org, sadrul@chromium.org

[sahel, 2016-05-27 15:51:14]

sadrul@chromium.org: Please review changes in 

piman@chromium.org: Please review changes in

[sahel, 2016-05-27 17:48:34]

sahel@chromium.org changed reviewers:
- piman@chromium.org

[sahel, 2016-05-27 17:54:59]

sahel@chromium.org changed reviewers:
+ nick@chromium.org

[sahel, 2016-05-27 17:54:59]

nick@chromium.org: Please review changes in content files

[ncarter (slow), 2016-05-27 20:31:55]

nick@chromium.org changed reviewers:
+ nasko@chromium.org
- nick@chromium.org

[ncarter (slow), 2016-05-27 20:31:56]

-nick, +nasko (I'm about to go dark, and nasko says he can take a look)

[nasko, 2016-05-27 22:35:04]

content/ LGTM with comments nit.

https://codereview.chromium.org/1993383002/diff/60001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/1993383002/diff/60001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:145: //
TODO(crbug.com/613628): Initialize latency info correctly for OOPIFs.
nit: Please use TODO(username): Text ... . See https://crbug.com/XXXXXX for more
details.

[sadrul, 2016-05-28 01:30:42]

lgtm

[piman, 2016-05-31 15:52:03]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-05-31 15:52:04]

lgtm

[sahel, 2016-06-06 15:23:35]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 15:23:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993383002/80001

[commit-bot: I haz the power, 2016-06-06 15:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 15:25:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sahel, 2016-06-06 15:38:58]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 15:39:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993383002/100001

[commit-bot: I haz the power, 2016-06-06 15:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 15:48:23]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[sahel, 2016-06-06 17:31:49]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 17:32:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993383002/120001

[commit-bot: I haz the power, 2016-06-06 19:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 19:02:55]

Dry run: This issue passed the CQ dry run.

[sahel, 2016-06-06 19:05:18]

On 2016/06/06 19:02:55, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Here is the changes in different patches:
patch 4: editing the TODO comments as the nit asked.
patch 5: patch 4 had a merge conflict
patch 6: after resolving the merge conflict the code didn't compile anymore,
apparently ProcessMouseWheelEvent was called with its old signature in
browser_plugin_guest.cc.
I updated the function call.

@nasko: please review the content/browser/browser_plugin/browser_plugin_guest.cc
which is newly added to the cl.

[sahel, 2016-06-06 19:05:34]

https://codereview.chromium.org/1993383002/diff/60001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/1993383002/diff/60001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_input_event_router.cc:145: //
TODO(crbug.com/613628): Initialize latency info correctly for OOPIFs.
On 2016/05/27 22:35:04, nasko (slow) wrote:
> nit: Please use TODO(username): Text ... . See https://crbug.com/XXXXXX for
more
> details.

Done.

[nasko, 2016-06-06 23:49:36]

nasko@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[nasko, 2016-06-06 23:49:38]

Adding wjmaclean@ as his alias is listed for quite a few TODOs :). I'm happy
with browser_plugin_guest.cc as long as he is.

[wjmaclean, 2016-06-07 12:13:25]

On 2016/06/06 23:49:38, nasko (slow) wrote:
> Adding wjmaclean@ as his alias is listed for quite a few TODOs :). I'm happy
> with browser_plugin_guest.cc as long as he is.

Sure, lgtm :-)

[sahel, 2016-06-07 14:26:38]

The CQ bit was checked by sahel@chromium.org

[sahel, 2016-06-07 14:26:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, sadrul@chromium.org, nasko@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1993383002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-06-07 14:26:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993383002/120001

[commit-bot: I haz the power, 2016-06-07 15:10:14]

Description was changed from

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry
latency info for mouse/mouseWheel events. The latency_info was needed for the
Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes
and/or overridden functions.

BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry
latency info for mouse/mouseWheel events. The latency_info was needed for the
Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes
and/or overridden functions.

BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-06-07 15:10:20]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-06-07 15:12:39]

Description was changed from

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry
latency info for mouse/mouseWheel events. The latency_info was needed for the
Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes
and/or overridden functions.

BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Adding Event.Latency.Browser.WheelUI, Passing latency_info to
ProcessMouse/MouseWheelEvent functions.

I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry
latency info for mouse/mouseWheel events. The latency_info was needed for the
Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes
and/or overridden functions.

BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d9c26df2531fb850b0f6523b3f55345a74a7ed51
Cr-Commit-Position: refs/heads/master@{#398302}
==========

[commit-bot: I haz the power, 2016-06-07 15:12:41]

Patchset 6 (id:??) landed as
https://crrev.com/d9c26df2531fb850b0f6523b3f55345a74a7ed51
Cr-Commit-Position: refs/heads/master@{#398302}