Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1993383002: Adding Event.Latency.Browser.WheelUI, Passing latency_info to ProcessMouse/MouseWheelEvent functions (Closed)

Created:
4 years, 7 months ago by sahel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, tdresser+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Event.Latency.Browser.WheelUI, Passing latency_info to ProcessMouse/MouseWheelEvent functions. I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry latency info for mouse/mouseWheel events. The latency_info was needed for the Event.Latency.Browser.WheelUI histogram. Many files are modified due to propagation of the two function signature changes and/or overridden functions. BUG=565346 TEST=MouseEventLatencyUIComponentExists, MouseWheelEventLatencyUIComponentExists CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/d9c26df2531fb850b0f6523b3f55345a74a7ed51 Cr-Commit-Position: refs/heads/master@{#398302}

Patch Set 1 : #

Total comments: 7

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -47 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 2 3 4 2 chunks +13 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 4 chunks +10 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 4 chunks +16 lines, -9 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 7 chunks +10 lines, -10 lines 0 comments Download
M ui/events/event.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M ui/events/event_unittest.cc View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 52 (27 generated)
sahel
I left the comments as they are, We need to replace them with a proper ...
4 years, 7 months ago (2016-05-20 17:09:22 UTC) #5
tdresser
Update TEST= line to "EventTest.MouseEventLatencyUIComponentExists, EventTest.MouseEventLatencyUIComponentExists" https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc File content/browser/frame_host/cross_process_frame_connector.cc (right): https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc#newcode177 content/browser/frame_host/cross_process_frame_connector.cc:177: //I can change ...
4 years, 7 months ago (2016-05-20 17:24:54 UTC) #6
sahel
https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc File content/browser/frame_host/cross_process_frame_connector.cc (right): https://codereview.chromium.org/1993383002/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc#newcode177 content/browser/frame_host/cross_process_frame_connector.cc:177: //I can change function signiture and pass latency to ...
4 years, 7 months ago (2016-05-20 18:38:20 UTC) #10
tdresser
LGTM with formatting nits. https://codereview.chromium.org/1993383002/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1993383002/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode1999 content/browser/renderer_host/render_widget_host_view_mac.mm:1999: 0, 0); On 2016/05/20 18:38:20, ...
4 years, 7 months ago (2016-05-20 18:45:53 UTC) #11
sahel
jam@chromium.org: Please review changes in https://codereview.chromium.org/1993383002/diff/40001/content/browser/frame_host/cross_process_frame_connector.cc File content/browser/frame_host/cross_process_frame_connector.cc (right): https://codereview.chromium.org/1993383002/diff/40001/content/browser/frame_host/cross_process_frame_connector.cc#newcode175 content/browser/frame_host/cross_process_frame_connector.cc:175: // TODO: https://bugs.chromium.org/p/chromium/issues/detail?id=613628 On ...
4 years, 7 months ago (2016-05-20 19:03:28 UTC) #13
sahel
cpu@chromium.org: Please review changes in
4 years, 7 months ago (2016-05-24 19:20:54 UTC) #16
sahel
sadrul@chromium.org: Please review changes in piman@chromium.org: Please review changes in
4 years, 6 months ago (2016-05-27 15:51:14 UTC) #19
sahel
nick@chromium.org: Please review changes in content files
4 years, 6 months ago (2016-05-27 17:54:59 UTC) #22
ncarter (slow)
-nick, +nasko (I'm about to go dark, and nasko says he can take a look)
4 years, 6 months ago (2016-05-27 20:31:56 UTC) #24
nasko
content/ LGTM with comments nit. https://codereview.chromium.org/1993383002/diff/60001/content/browser/renderer_host/render_widget_host_input_event_router.cc File content/browser/renderer_host/render_widget_host_input_event_router.cc (right): https://codereview.chromium.org/1993383002/diff/60001/content/browser/renderer_host/render_widget_host_input_event_router.cc#newcode145 content/browser/renderer_host/render_widget_host_input_event_router.cc:145: // TODO(crbug.com/613628): Initialize latency ...
4 years, 6 months ago (2016-05-27 22:35:04 UTC) #25
sadrul
lgtm
4 years, 6 months ago (2016-05-28 01:30:42 UTC) #26
piman
lgtm
4 years, 6 months ago (2016-05-31 15:52:04 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993383002/80001
4 years, 6 months ago (2016-06-06 15:23:50 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/16666) ios-simulator-gn on ...
4 years, 6 months ago (2016-06-06 15:25:42 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993383002/100001
4 years, 6 months ago (2016-06-06 15:39:15 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/77029)
4 years, 6 months ago (2016-06-06 15:48:23 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993383002/120001
4 years, 6 months ago (2016-06-06 17:32:51 UTC) #38
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 19:02:55 UTC) #40
sahel
On 2016/06/06 19:02:55, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-06-06 19:05:18 UTC) #41
sahel
https://codereview.chromium.org/1993383002/diff/60001/content/browser/renderer_host/render_widget_host_input_event_router.cc File content/browser/renderer_host/render_widget_host_input_event_router.cc (right): https://codereview.chromium.org/1993383002/diff/60001/content/browser/renderer_host/render_widget_host_input_event_router.cc#newcode145 content/browser/renderer_host/render_widget_host_input_event_router.cc:145: // TODO(crbug.com/613628): Initialize latency info correctly for OOPIFs. On ...
4 years, 6 months ago (2016-06-06 19:05:34 UTC) #42
nasko
Adding wjmaclean@ as his alias is listed for quite a few TODOs :). I'm happy ...
4 years, 6 months ago (2016-06-06 23:49:38 UTC) #44
wjmaclean
On 2016/06/06 23:49:38, nasko (slow) wrote: > Adding wjmaclean@ as his alias is listed for ...
4 years, 6 months ago (2016-06-07 12:13:25 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993383002/120001
4 years, 6 months ago (2016-06-07 14:26:52 UTC) #48
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 6 months ago (2016-06-07 15:10:20 UTC) #50
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 15:12:41 UTC) #52
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d9c26df2531fb850b0f6523b3f55345a74a7ed51
Cr-Commit-Position: refs/heads/master@{#398302}

Powered by Google App Engine
This is Rietveld 408576698