Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/renderer/resources/media_router_bindings.js

Issue 1993373002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/media/router/issue.h ('K') | « chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/media_router_bindings.js
diff --git a/extensions/renderer/resources/media_router_bindings.js b/extensions/renderer/resources/media_router_bindings.js
index bb6597abd971494860dcc0017b29d673247b9ead..f9771e8868ef934d0be09c3ea4a4c17f588738a7 100644
--- a/extensions/renderer/resources/media_router_bindings.js
+++ b/extensions/renderer/resources/media_router_bindings.js
@@ -353,7 +353,7 @@ define('media_router_bindings', [
'message': issue.message,
'default_action': issueActionToMojo_(issue.defaultAction),
'secondary_actions': secondaryActions,
- 'help_url': issue.helpUrl,
+ 'help_page_id': issue.help_page_id,
imcheng 2016/05/23 20:02:42 nit: issue.helpPageId.
apacible 2016/05/23 20:22:52 Done.
'is_blocking': issue.isBlocking
}));
};
« chrome/browser/media/router/issue.h ('K') | « chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698