Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1993343002: PPC/S390: [Interpreter] Support compiling for baseline on return from interpreted function. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/S390: [Interpreter] Support compiling for baseline on return from interpreted function. port f241a61a3409cef1f8d631d5c3ee992e182f294e Original Commit Message: We cannot tier up from interpreted to baseline code when there is an activation of the function on the stack. This significantly regresses the performance of recursive functions since they are unlikely to get tiered up. This CL adds the ability for a function to be marked for baseline compilation when it returns. To do this we patch the InterpreterEntryTrampoline return address to point to InterpreterMarkBaselineOnReturn, which leaves the interpreted frame and recompile the function for baseline. This improves the score of EarlyBoyer by ~8x for Ignition. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/31ac67ee61c430f1f66e9d4e707d60b76578e8b7 Cr-Commit-Position: refs/heads/master@{#36384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -18 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +39 lines, -9 lines 0 comments Download
M src/s390/builtins-s390.cc View 3 chunks +41 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-19 19:36:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993343002/1
4 years, 7 months ago (2016-05-19 19:36:30 UTC) #3
MTBrandyberry
LGTM for PPC
4 years, 7 months ago (2016-05-19 19:49:15 UTC) #4
JoranSiu
LGTM for S390
4 years, 7 months ago (2016-05-19 19:55:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 19:56:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993343002/1
4 years, 7 months ago (2016-05-19 20:04:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 20:06:06 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:06:29 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31ac67ee61c430f1f66e9d4e707d60b76578e8b7
Cr-Commit-Position: refs/heads/master@{#36384}

Powered by Google App Engine
This is Rietveld 408576698