Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/browser/gpu/browser_gpu_memory_buffer_manager.h

Issue 1993333002: Implement GpuMemoryBufferManager::CreateGpuMemoryBufferFromClientId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restrict to IOSurface, add traces Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/browser_gpu_memory_buffer_manager.h
diff --git a/content/browser/gpu/browser_gpu_memory_buffer_manager.h b/content/browser/gpu/browser_gpu_memory_buffer_manager.h
index 75db1395847653d1fa3f661ab8ed0bc0cb6bdfbd..c6f180bbf2bb90edc70c6fda51896f274fc730bb 100644
--- a/content/browser/gpu/browser_gpu_memory_buffer_manager.h
+++ b/content/browser/gpu/browser_gpu_memory_buffer_manager.h
@@ -29,6 +29,10 @@ using GpuMemoryBufferConfigurationSet =
} // content
+namespace gpu {
+class GpuMemoryBufferImpl;
+} // gpu
+
namespace BASE_HASH_NAMESPACE {
template <>
@@ -111,7 +115,7 @@ class CONTENT_EXPORT BrowserGpuMemoryBufferManager
gfx::BufferFormat format,
gfx::BufferUsage usage,
int gpu_host_id);
- BufferInfo(const BufferInfo& other);
+ BufferInfo(BufferInfo&& other);
~BufferInfo();
gfx::Size size;
@@ -119,6 +123,11 @@ class CONTENT_EXPORT BrowserGpuMemoryBufferManager
gfx::BufferFormat format = gfx::BufferFormat::RGBA_8888;
gfx::BufferUsage usage = gfx::BufferUsage::GPU_READ;
int gpu_host_id = 0;
+
+ // For buffers created for a child process, open an instance of the
+ // buffer in the browser process for future use by
+ // CreateGpuMemoryBufferFromClientId.
+ std::unique_ptr<gpu::GpuMemoryBufferImpl> parent_buffer_instance;
reveman 2016/05/24 22:19:47 This is not just needed for FromClientId. It's nee
ccameron 2016/05/24 22:58:04 Definitely agree with this long-term. Removing the
};
struct CreateGpuMemoryBufferRequest;

Powered by Google App Engine
This is Rietveld 408576698