Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1993293002: fix #577 - correctly toString ES Symbols (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
sra1, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M test/browser/runtime_tests.js View 1 chunk +5 lines, -0 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Stephen may have some follow ups in the works that tweak the performance further?
4 years, 7 months ago (2016-05-19 19:01:14 UTC) #2
sra1
LGTM. I'll do the other change later.
4 years, 7 months ago (2016-05-19 19:28:50 UTC) #3
Jennifer Messerly
4 years, 7 months ago (2016-05-19 19:33:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e097a96184da0bf3d95fc0dce19a55175d4add9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698