Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1993263002: Make GrAppliedClip friendless (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrAppliedClip friendless GrAppliedClip is a pretty amiable class but not so good about setting boundaries. It is probably for the best that it breaks things off with GrClipMaskManager before the drama of https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) begins. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993263002 Committed: https://skia.googlesource.com/skia/+/5f2fa47a6ea50653fa1584d6baeabce50698881c

Patch Set 1 #

Patch Set 2 : Make GrAppliedClip friendless #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -22 lines) Patch
M include/gpu/GrClip.h View 1 chunk +31 lines, -8 lines 0 comments Download
M src/gpu/GrClip.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 8 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 7 months ago (2016-05-19 16:50:35 UTC) #4
bsalomon
lgtm, Hope it doesn't get lonely.
4 years, 7 months ago (2016-05-19 17:23:53 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993263002/20001
4 years, 7 months ago (2016-05-19 18:02:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 18:22:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993263002/20001
4 years, 7 months ago (2016-05-19 18:35:31 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:36:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5f2fa47a6ea50653fa1584d6baeabce50698881c

Powered by Google App Engine
This is Rietveld 408576698