Fix omnibox flashing on phones when switching between foreground/background NTPs

Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114
Committed: https://crrev.com/4648bfe49691cfcedcb719c349c1c524aac7bd3b
Cr-Commit-Position: refs/heads/master@{#394812}

[May, 2016-05-19 16:07:49]

maybelle@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-05-19 16:29:12]

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:74:
private Context mContext;
Make this final?

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java
(right):

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java:57:
public static int getTextBoxColorForToolbarBackground(Resources res, boolean
isNtp, int color) {
I wonder whether we should pass in the tab here as well, like we do in
getTextBoxAlphaForToolbarBackground() below?

[May, 2016-05-19 16:31:39]

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java
(right):

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java:57:
public static int getTextBoxColorForToolbarBackground(Resources res, boolean
isNtp, int color) {
On 2016/05/19 16:29:12, Bernhard Bauer wrote:
> I wonder whether we should pass in the tab here as well, like we do in
> getTextBoxAlphaForToolbarBackground() below?

Yeah, maybe that's better since there's already precedent for doing that in this
file.... I'll change it.

[Bernhard Bauer, 2016-05-19 16:52:10]

Description was changed from

==========
Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114
==========

to

==========
Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114
==========

[May, 2016-05-19 17:01:06]

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://codereview.chromium.org/1993253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:74:
private Context mContext;
On 2016/05/19 16:29:12, Bernhard Bauer wrote:
> Make this final?

Done.

[Bernhard Bauer, 2016-05-19 17:05:49]

lgtm

[May, 2016-05-19 17:08:02]

The CQ bit was checked by maybelle@chromium.org

[commit-bot: I haz the power, 2016-05-19 17:08:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993253002/40001

[commit-bot: I haz the power, 2016-05-19 18:06:37]

Description was changed from

==========
Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114
==========

to

==========
Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114
==========

[commit-bot: I haz the power, 2016-05-19 18:06:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-19 18:08:18]

Description was changed from

==========
Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114
==========

to

==========
Fix omnibox flashing on phones when switching between foreground/background NTPs

BUG=612114

Committed: https://crrev.com/4648bfe49691cfcedcb719c349c1c524aac7bd3b
Cr-Commit-Position: refs/heads/master@{#394812}
==========

[commit-bot: I haz the power, 2016-05-19 18:08:19]

Patchset 3 (id:??) landed as
https://crrev.com/4648bfe49691cfcedcb719c349c1c524aac7bd3b
Cr-Commit-Position: refs/heads/master@{#394812}